Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: tools/telemetry/telemetry/page/page_set.py

Issue 965543002: Remove the ability to shuffle page_sets from user_story_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use filter for Dave! Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/user_story/user_story_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_set.py
diff --git a/tools/telemetry/telemetry/page/page_set.py b/tools/telemetry/telemetry/page/page_set.py
index a4ddc1e4206950125cceea161d2f59636235fcd0..18d4bf45f0414e5f76429bb057f6a9a51b38defa 100644
--- a/tools/telemetry/telemetry/page/page_set.py
+++ b/tools/telemetry/telemetry/page/page_set.py
@@ -56,27 +56,3 @@ class PageSet(user_story_set.UserStorySet):
return os.path.dirname(self.file_path)
else:
return self.file_path
-
- def ReorderPageSet(self, results_file):
- """Reorders this page set based on the results of a past run."""
- page_set_dict = {}
- for page in self.user_stories:
- page_set_dict[page.url] = page
-
- user_stories = []
- with open(results_file, 'rb') as csv_file:
- csv_reader = csv.reader(csv_file)
- csv_header = csv_reader.next()
-
- if 'url' not in csv_header:
- raise Exception('Unusable results_file.')
-
- url_index = csv_header.index('url')
-
- for csv_row in csv_reader:
- if csv_row[url_index] in page_set_dict:
- self.AddUserStory(page_set_dict[csv_row[url_index]])
- else:
- raise Exception('Unusable results_file.')
-
- return user_stories
« no previous file with comments | « no previous file | tools/telemetry/telemetry/user_story/user_story_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698