Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 965463003: Remove an old constructor from WebNotificationData, add a layout test. (Closed)

Created:
5 years, 10 months ago by Peter Beverloo
Modified:
5 years, 9 months ago
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove an old constructor from WebNotificationData, add a layout test. Now that the users in Chromium pass the "silent" flag as well, we can remove the old constructor. This patch also introduces a test to verify that the "silent" attribute will be properly reflected in the Notification object received in the "notificationclick" event, as well as reflection in a newly created Notification object through the constructor. This is part of a three-sided patch: [1] https://codereview.chromium.org/960163003/ [2] https://codereview.chromium.org/965573002/ [3] This patch. BUG=442134 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191705

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -26 lines) Patch
M LayoutTests/http/tests/notifications/notification-properties.html View 1 2 3 4 3 chunks +4 lines, -1 line 0 comments Download
A + LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html View 1 2 3 4 4 chunks +25 lines, -13 lines 0 comments Download
M public/platform/modules/notifications/WebNotificationData.h View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Peter Beverloo
+mvanouwerkerk for review
5 years, 10 months ago (2015-02-26 23:08:13 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 9 months ago (2015-02-27 11:31:32 UTC) #3
Peter Beverloo
Michael, can you please review the layout test changes I just added to this patch?
5 years, 9 months ago (2015-03-02 18:49:53 UTC) #4
Michael van Ouwerkerk
also lgtm
5 years, 9 months ago (2015-03-03 12:28:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965463003/80001
5 years, 9 months ago (2015-03-11 11:33:37 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 14:22:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191705

Powered by Google App Engine
This is Rietveld 408576698