Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: public/platform/modules/notifications/WebNotificationData.h

Issue 965463003: Remove an old constructor from WebNotificationData, add a layout test. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebNotificationData_h 5 #ifndef WebNotificationData_h
6 #define WebNotificationData_h 6 #define WebNotificationData_h
7 7
8 #include "public/platform/WebString.h" 8 #include "public/platform/WebString.h"
9 #include "public/platform/WebURL.h" 9 #include "public/platform/WebURL.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 // Structure representing the data associated with a Web Notification. 13 // Structure representing the data associated with a Web Notification.
14 struct WebNotificationData { 14 struct WebNotificationData {
15 enum Direction { 15 enum Direction {
16 DirectionLeftToRight, 16 DirectionLeftToRight,
17 DirectionRightToLeft 17 DirectionRightToLeft
18 }; 18 };
19 19
20 WebNotificationData() 20 WebNotificationData()
21 : direction(DirectionLeftToRight) 21 : direction(DirectionLeftToRight)
22 , silent(false) 22 , silent(false)
23 { 23 {
24 } 24 }
25 25
26 // FIXME: Remove this constructor when Chromium has switched to the new one.
27 WebNotificationData(const WebString& title, Direction direction, const WebSt ring& lang, const WebString& body, const WebString& tag, const WebURL& icon)
28 : title(title)
29 , direction(direction)
30 , lang(lang)
31 , body(body)
32 , tag(tag)
33 , icon(icon)
34 , silent(false)
35 {
36 }
37
38 WebNotificationData(const WebString& title, Direction direction, const WebSt ring& lang, const WebString& body, const WebString& tag, const WebURL& icon, boo l silent) 26 WebNotificationData(const WebString& title, Direction direction, const WebSt ring& lang, const WebString& body, const WebString& tag, const WebURL& icon, boo l silent)
39 : title(title) 27 : title(title)
40 , direction(direction) 28 , direction(direction)
41 , lang(lang) 29 , lang(lang)
42 , body(body) 30 , body(body)
43 , tag(tag) 31 , tag(tag)
44 , icon(icon) 32 , icon(icon)
45 , silent(silent) 33 , silent(silent)
46 { 34 {
47 } 35 }
48 36
49 WebString title; 37 WebString title;
50 Direction direction; 38 Direction direction;
51 WebString lang; 39 WebString lang;
52 WebString body; 40 WebString body;
53 WebString tag; 41 WebString tag;
54 WebURL icon; 42 WebURL icon;
55 bool silent; 43 bool silent;
56 }; 44 };
57 45
58 } // namespace blink 46 } // namespace blink
59 47
60 #endif // WebNotificationData_h 48 #endif // WebNotificationData_h
OLDNEW
« no previous file with comments | « LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698