Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 965093002: [Cast] Crash fix for certain vp8 video frame resize attempts. (Closed)

Created:
5 years, 9 months ago by miu
Modified:
5 years, 9 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cast] Crash fix for certain vp8 video frame resize attempts. BUG=462799 TEST=Resized CrOS Ash-desktop-in-a-window on my local dev workstation to confirm crash is resolved. Committed: https://crrev.com/2bed4c9de3ecdc76a1457c9188b1ec4c382bf934 Cr-Commit-Position: refs/heads/master@{#318767}

Patch Set 1 #

Total comments: 2

Patch Set 2 : s/libvp8/libvpx/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M media/cast/sender/vp8_encoder.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
miu
hclam: PTAL. Simple code change for crash fix (see bug).
5 years, 9 months ago (2015-02-28 00:35:01 UTC) #2
Alpha Left Google
On 2015/02/28 00:35:01, miu wrote: > hclam: PTAL. Simple code change for crash fix (see ...
5 years, 9 months ago (2015-02-28 00:38:25 UTC) #3
Alpha Left Google
https://codereview.chromium.org/965093002/diff/1/media/cast/sender/vp8_encoder.cc File media/cast/sender/vp8_encoder.cc (right): https://codereview.chromium.org/965093002/diff/1/media/cast/sender/vp8_encoder.cc#newcode85 media/cast/sender/vp8_encoder.cc:85: DVLOG(1) << "libvp8 rejected the attempt to use a ...
5 years, 9 months ago (2015-02-28 01:08:36 UTC) #4
miu
https://codereview.chromium.org/965093002/diff/1/media/cast/sender/vp8_encoder.cc File media/cast/sender/vp8_encoder.cc (right): https://codereview.chromium.org/965093002/diff/1/media/cast/sender/vp8_encoder.cc#newcode85 media/cast/sender/vp8_encoder.cc:85: DVLOG(1) << "libvp8 rejected the attempt to use a ...
5 years, 9 months ago (2015-02-28 02:10:15 UTC) #5
Alpha Left Google
LGTM based on offline discussion. If the call fails then a new encoder will be ...
5 years, 9 months ago (2015-03-02 20:28:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965093002/20001
5 years, 9 months ago (2015-03-02 20:31:54 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-02 21:38:49 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 21:39:26 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2bed4c9de3ecdc76a1457c9188b1ec4c382bf934
Cr-Commit-Position: refs/heads/master@{#318767}

Powered by Google App Engine
This is Rietveld 408576698