[Cast] Crash fix for certain vp8 video frame resize attempts.

media/cast/sender/vp8_encoder.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cast/sender/vp8_encoder.h"
 
 #include "base/logging.h"
 #include "media/base/video_frame.h"
 #include "media/cast/cast_defines.h"
 #include "media/cast/net/cast_transport_config.h"
@@ skipping 62 matching lines @@
     // the old size, in terms of area, the existing encoder instance can
     // continue.  Otherwise, completely tear-down and re-create a new encoder to
     // avoid a shutdown crash.
     if (frame_size.GetArea() <= gfx::Size(config_.g_w, config_.g_h).GetArea() &&
         !use_multiple_video_buffers_) {
       DVLOG(1) << "Continuing to use existing encoder at smaller frame size: "
                << gfx::Size(config_.g_w, config_.g_h).ToString() << " --> "
                << frame_size.ToString();
       config_.g_w = frame_size.width();
       config_.g_h = frame_size.height();
-      CHECK_EQ(vpx_codec_enc_config_set(&encoder_, &config_), VPX_CODEC_OK)
-          << "Failed to update frame size in encoder config.";
-      return;
+      if (vpx_codec_enc_config_set(&encoder_, &config_) == VPX_CODEC_OK)
+        return;
+      DVLOG(1) << "libvp8 rejected the attempt to use a smaller frame size in "

[Alpha Left Google, 2015/02/28 01:08:36]

nit: libvpx.

[miu, 2015/02/28 02:10:15]

Done.

+                  "the current instance.";
     }
 
     DVLOG(1) << "Destroying/Re-Creating encoder for larger frame size: "
              << gfx::Size(config_.g_w, config_.g_h).ToString() << " --> "
              << frame_size.ToString();
     vpx_codec_destroy(&encoder_);
   } else {
     DVLOG(1) << "Creating encoder for the first frame; size: "
              << frame_size.ToString();
   }
@@ skipping 373 matching lines @@
   }
 }
 
 void Vp8Encoder::GenerateKeyFrame() {
   DCHECK(thread_checker_.CalledOnValidThread());
   key_frame_requested_ = true;
 }
 
 }  // namespace cast
 }  // namespace media