Issue 964603002: Add sqrt() and rsqrt() to Sk4f.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 964603002: Add sqrt() and rsqrt() to Sk4f. (Closed)

Created:
5 years, 10 months ago by mtklein_C

Modified:
5 years, 10 months ago

Reviewers:
mtklein, reed2, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Add sqrt() and rsqrt() to Sk4f. This doesn't add them to the second-stringer Sk4i. It's unclear we should be doing that often, and we don't have efficient ways to do it except via floats. BUG=skia: Committed: https://skia.googlesource.com/skia/+/24aa0f0679d5299b394bcb62b1c4430e4cd34c65

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -0 lines)			Patch
M	src/core/Sk4x.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/core/Sk4x_portable.h	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
M	src/core/Sk4x_sse.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/Sk4xTest.cpp	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964603002/20001

5 years, 10 months ago (2015-02-26 20:42:30 UTC) #6

commit-bot: I haz the power

5 years, 10 months ago (2015-02-26 20:48:09 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/24aa0f0679d5299b394bcb62b1c4430e4cd34c65