Issue 964533003: Files.app: Fix task cancellation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 964533003: Files.app: Fix task cancellation. (Closed)

Created:
5 years, 9 months ago by Steve McKay

Modified:
5 years, 9 months ago

Reviewers:

CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2311

Target Ref:
refs/pending/branch-heads/2311

Project:
chromium

Visibility:
Public.

More Reviews

Description

Files.app: Fix task cancellation. - Fix the task queue so that cancelling a task doesn't leave it hanging out in the queue, which then will jam everything up. - Fix the error code so that errors are handled consistently (and are non-terminal, as they should be) - Rename UpdateType.SUCCESS to UpdateType.COMPLETE. This better reflects the fact that errors can occur during an import task but the task still runs to completion. BUG=460597 Review URL: https://codereview.chromium.org/947583002 Cr-Commit-Position: refs/heads/master@{#317538} (cherry picked from commit fb5551a709a997209e1504d0eacc8562c1740f03) TBR=mtomasz Committed: https://chromium.googlesource.com/chromium/src/+/417ae4e540cfbb3570b2687c1544d59e73f640ce

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+134 lines, -38 lines)			Patch
M	ui/file_manager/file_manager/background/js/media_import_handler.js	View	5 chunks	+16 lines, -19 lines	0 comments	Download
M	ui/file_manager/file_manager/background/js/media_import_handler_unittest.js	View	9 chunks	+76 lines, -5 lines	0 comments	Download
M	ui/file_manager/file_manager/background/js/task_queue.js	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	ui/file_manager/file_manager/background/js/task_queue_unittest.js	View	8 chunks	+38 lines, -11 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Steve McKay

5 years, 9 months ago (2015-02-26 20:07:23 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
417ae4e540cfbb3570b2687c1544d59e73f640ce (presubmit successful).

Expand Messages | Collapse Messages