Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 947583002: Files.app: Fix task cancellation. (Closed)

Created:
5 years, 10 months ago by Ben Kwa
Modified:
5 years, 10 months ago
Reviewers:
mtomasz, Steve McKay
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Fix task cancellation. - Fix the task queue so that cancelling a task doesn't leave it hanging out in the queue, which then will jam everything up. - Fix the error code so that errors are handled consistently (and are non-terminal, as they should be) - Rename UpdateType.SUCCESS to UpdateType.COMPLETE. This better reflects the fact that errors can occur during an import task but the task still runs to completion. BUG=460597 Committed: https://crrev.com/fb5551a709a997209e1504d0eacc8562c1740f03 Cr-Commit-Position: refs/heads/master@{#317538}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -38 lines) Patch
M ui/file_manager/file_manager/background/js/media_import_handler.js View 5 chunks +16 lines, -19 lines 2 comments Download
M ui/file_manager/file_manager/background/js/media_import_handler_unittest.js View 9 chunks +76 lines, -5 lines 0 comments Download
M ui/file_manager/file_manager/background/js/task_queue.js View 3 chunks +4 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/background/js/task_queue_unittest.js View 8 chunks +38 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Ben Kwa
5 years, 10 months ago (2015-02-20 22:12:25 UTC) #2
Steve McKay
LGTM. Please add a tab column to the backlog where we can track changes that ...
5 years, 10 months ago (2015-02-20 22:30:02 UTC) #3
mtomasz
lgtm https://codereview.chromium.org/947583002/diff/1/ui/file_manager/file_manager/background/js/media_import_handler.js File ui/file_manager/file_manager/background/js/media_import_handler.js (right): https://codereview.chromium.org/947583002/diff/1/ui/file_manager/file_manager/background/js/media_import_handler.js#newcode124 ui/file_manager/file_manager/background/js/media_import_handler.js:124: break; nit: indent
5 years, 10 months ago (2015-02-23 00:59:22 UTC) #4
Steve McKay
Ben's got a bunch of extra curricular activities next week. I'm gonna this the commit ...
5 years, 10 months ago (2015-02-23 03:17:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947583002/1
5 years, 10 months ago (2015-02-23 03:18:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 03:24:27 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fb5551a709a997209e1504d0eacc8562c1740f03 Cr-Commit-Position: refs/heads/master@{#317538}
5 years, 10 months ago (2015-02-23 03:24:59 UTC) #9
Steve McKay
On 2015/02/23 03:24:59, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 10 months ago (2015-02-23 18:20:41 UTC) #10
Steve McKay
5 years, 10 months ago (2015-02-24 18:15:29 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org/947583002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/background/js/media_import_handler.js (right):

https://codereview.chromium.org/947583002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/background/js/media_import_handler.js:124: break;
On 2015/02/23 00:59:22, mtomasz wrote:
> nit: indent

Fixed in followup CL.

Powered by Google App Engine
This is Rietveld 408576698