chrome/common/pref_names.cc - Issue 964503002: Implemented ForceMaximizeBrowserWindowOnFirstRun policy, added unit test and browser test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/pref_names.cc

Issue 964503002: Implemented ForceMaximizeBrowserWindowOnFirstRun policy, added unit test and browser test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix after review Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/chrome_shell_delegate.cc ('K') | « chrome/common/pref_names.h ('k') | chrome/test/data/policy/policy_test_cases.json » ('j') | components/policy/resources/policy_templates.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/pref_names.cc

diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc

index 61151eb1ef3ebcc5937aa2d18c2b105e5fd5e473..f094eaea0b363b2f415d9cc800cc48214111b094 100644

--- a/chrome/common/pref_names.cc

+++ b/chrome/common/pref_names.cc

@@ -817,6 +817,11 @@ const char kWakeOnWifiSsid[] = "settings.internet.wake_on_wifi_ssid";

// which allows to bypass the user's proxy for captive portal authentication.

const char kCaptivePortalAuthenticationIgnoresProxy[] =

"proxy.captive_portal_ignores_proxy";

+// This boolean controls whether the first window shown on first run should be

bartfab (slow) 2015/04/01 14:22:43 Nit: Add blank line above.

peletskyi 2015/04/01 18:55:47 Done.

+// unconditionally maximized, overriding the heuristic that normally chooses the

+// window size.

+const char kForceMaximizeOnFirstRun[] =

bartfab (slow) 2015/04/01 14:22:43 Nit: This fits on one line.

peletskyi 2015/04/01 18:55:47 Done.

+ "ui.force_maximize_on_first_run";

#endif // defined(OS_CHROMEOS)

// The disabled messages in IPC logging.