Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: chrome/browser/ui/ash/chrome_shell_delegate.cc

Issue 964503002: Implemented ForceMaximizeBrowserWindowOnFirstRun policy, added unit test and browser test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix after review Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/chrome_shell_delegate.cc
diff --git a/chrome/browser/ui/ash/chrome_shell_delegate.cc b/chrome/browser/ui/ash/chrome_shell_delegate.cc
index 88998525db8117bb5342cdda7a63554ce6da4a56..7cc24ad8d2370a06b759c66286b662cccfd53d94 100644
--- a/chrome/browser/ui/ash/chrome_shell_delegate.cc
+++ b/chrome/browser/ui/ash/chrome_shell_delegate.cc
@@ -7,8 +7,11 @@
#include "ash/content_support/gpu_support_impl.h"
#include "ash/wm/window_state.h"
#include "ash/wm/window_util.h"
+#include "base/prefs/pref_service.h"
bartfab (slow) 2015/04/01 14:22:43 Nit: Move this to the #if defined(OS_CHROMEOS) sec
peletskyi 2015/04/01 18:55:47 Done.
#include "chrome/browser/app_mode/app_mode_utils.h"
+#include "chrome/browser/chromeos/profiles/profile_helper.h"
bartfab (slow) 2015/04/01 14:22:43 Nit: Move this to the #if defined(OS_CHROMEOS) sec
peletskyi 2015/04/01 18:55:47 Done.
#include "chrome/browser/lifetime/application_lifetime.h"
+#include "chrome/browser/profiles/profile.h"
bartfab (slow) 2015/04/01 14:22:43 Nit: Move this to the #if defined(OS_CHROMEOS) sec
peletskyi 2015/04/01 18:55:47 Done.
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/profiles/profiles_state.h"
#include "chrome/browser/ui/app_list/app_list_view_delegate.h"
@@ -17,6 +20,7 @@
#include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
#include "chrome/browser/ui/ash/launcher/launcher_context_menu.h"
#include "chrome/browser/ui/browser_commands.h"
+#include "chrome/common/pref_names.h"
bartfab (slow) 2015/04/01 14:22:43 Nit: Move this to the #if defined(OS_CHROMEOS) sec
peletskyi 2015/04/01 18:55:47 Done.
#include "chrome/grit/chromium_strings.h"
#include "components/signin/core/common/profile_management_switches.h"
#include "ui/base/l10n/l10n_util.h"
@@ -88,6 +92,19 @@ bool ChromeShellDelegate::IsMultiAccountEnabled() const {
return false;
}
+bool ChromeShellDelegate::ForceMaximizeOnFirstRun() const {
+#if defined(OS_CHROMEOS)
+ const user_manager::User* const user =
bartfab (slow) 2015/04/01 14:22:43 Nit: #include "components/user_manager/user.h"
peletskyi 2015/04/01 18:55:47 Done.
+ user_manager::UserManager::Get()->GetActiveUser();
+ if (user)
bartfab (slow) 2015/04/01 14:22:43 Nit: Add curly braces.
peletskyi 2015/04/01 18:55:47 Done.
+ return chromeos::ProfileHelper::Get()
+ ->GetProfileByUser(user)
+ ->GetPrefs()
+ ->GetBoolean(prefs::kForceMaximizeOnFirstRun);
+#endif
+ return false;
+}
+
void ChromeShellDelegate::Exit() {
chrome::AttemptUserExit();
}

Powered by Google App Engine
This is Rietveld 408576698