Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 964493002: DevTools: improve TTIE, do not select body before the target element upon inspect element. (Closed)

Created:
5 years, 10 months ago by pfeldman
Modified:
5 years, 9 months ago
Reviewers:
dgozman, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: improve TTIE, do not select body before the target element upon inspect element. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191029

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : rebaselined #

Patch Set 4 : headless test fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -68 lines) Patch
M LayoutTests/inspector-protocol/dom/dom-setInspectModeEnabled.html View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M Source/core/inspector/InjectedScript.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InjectedScript.cpp View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorController.cpp View 1 chunk +1 line, -16 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 2 3 3 chunks +13 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorInspectorAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorInspectorAgent.cpp View 2 chunks +1 line, -10 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 1 2 3 3 chunks +16 lines, -8 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
pfeldman
5 years, 10 months ago (2015-02-26 15:45:57 UTC) #2
dgozman
https://codereview.chromium.org/964493002/diff/20001/Source/core/inspector/InspectorDOMAgent.cpp File Source/core/inspector/InspectorDOMAgent.cpp (left): https://codereview.chromium.org/964493002/diff/20001/Source/core/inspector/InspectorDOMAgent.cpp#oldcode588 Source/core/inspector/InspectorDOMAgent.cpp:588: setDocument(m_pageAgent->inspectedFrame()->document()); You are missing |reset| and |m_frontend->documentUpdated| calls. https://codereview.chromium.org/964493002/diff/20001/Source/devtools/front_end/elements/ElementsPanel.js ...
5 years, 10 months ago (2015-02-26 16:05:16 UTC) #3
pfeldman
https://codereview.chromium.org/964493002/diff/20001/Source/core/inspector/InspectorDOMAgent.cpp File Source/core/inspector/InspectorDOMAgent.cpp (left): https://codereview.chromium.org/964493002/diff/20001/Source/core/inspector/InspectorDOMAgent.cpp#oldcode588 Source/core/inspector/InspectorDOMAgent.cpp:588: setDocument(m_pageAgent->inspectedFrame()->document()); That is intentional, enabling agent should not report ...
5 years, 9 months ago (2015-02-27 12:33:09 UTC) #4
dgozman
Btw, did you measure the TTIE improvement? lgtm
5 years, 9 months ago (2015-02-27 12:47:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964493002/40001
5 years, 9 months ago (2015-02-27 13:32:05 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/49415)
5 years, 9 months ago (2015-02-27 19:52:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964493002/60001
5 years, 9 months ago (2015-02-27 20:29:17 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 21:46:52 UTC) #14
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191029

Powered by Google App Engine
This is Rietveld 408576698