Source/devtools/front_end/sdk/DOMModel.js - Issue 964493002: DevTools: improve TTIE, do not select body before the target element upon inspect element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sdk/DOMModel.js

Issue 964493002: DevTools: improve TTIE, do not select body before the target element upon inspect element. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: headless test fixed Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/sdk/DOMModel.js

diff --git a/Source/devtools/front_end/sdk/DOMModel.js b/Source/devtools/front_end/sdk/DOMModel.js

index 45c8aee64ee36653b7f4d0b8f7e4494669080e4f..7e8bf131eba44c199392fc280127e2a21a3aa43f 100644

--- a/Source/devtools/front_end/sdk/DOMModel.js

+++ b/Source/devtools/front_end/sdk/DOMModel.js

@@ -1155,6 +1155,7 @@ WebInspector.DOMModel.prototype = {

resumeModel: function()

{

this._agent.enable();

+ this._setDocument(null);

/**

@@ -1580,11 +1581,12 @@ WebInspector.DOMModel.prototype = {

/**

- * @param {!DOMAgent.NodeId} nodeId

+ * @param {!DOMAgent.BackendNodeId} backendNodeId

- _inspectNodeRequested: function(nodeId)

+ _inspectNodeRequested: function(backendNodeId)

{

- this.dispatchEventToListeners(WebInspector.DOMModel.Events.NodeInspected, this.nodeForId(nodeId));

+ var deferredNode = new WebInspector.DeferredDOMNode(this.target(), backendNodeId);

+ this.dispatchEventToListeners(WebInspector.DOMModel.Events.NodeInspected, deferredNode);

/**

« no previous file with comments | « Source/devtools/front_end/main/Main.js ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »