Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 964473003: Disable MetricsServiceBrowserTest.CrashRenderers under ASan. (Closed)

Created:
5 years, 9 months ago by Nico
Modified:
5 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, Timur Iskhodzhanov, Ilya Sherman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable MetricsServiceBrowserTest.CrashRenderers under ASan. BUG=411251, 368525 Committed: https://crrev.com/a1f82f233fcad2b5158a8a5d3ba3ad337f10f1be Cr-Commit-Position: refs/heads/master@{#318526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/metrics/metrics_service_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Nico
first to stamp wins!
5 years, 9 months ago (2015-02-27 21:07:50 UTC) #2
Nico
err, i mean Alexei, not Ilya
5 years, 9 months ago (2015-02-27 21:10:07 UTC) #4
Reid Kleckner
lgtm
5 years, 9 months ago (2015-02-27 21:16:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964473003/1
5 years, 9 months ago (2015-02-27 21:18:49 UTC) #8
Alexei Svitkine (slow)
lgtm
5 years, 9 months ago (2015-02-27 21:19:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 22:04:26 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 22:05:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1f82f233fcad2b5158a8a5d3ba3ad337f10f1be
Cr-Commit-Position: refs/heads/master@{#318526}

Powered by Google App Engine
This is Rietveld 408576698