chrome/browser/metrics/metrics_service_browsertest.cc - Issue 964473003: Disable MetricsServiceBrowserTest.CrashRenderers under ASan.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service_browsertest.cc

Issue 964473003: Disable MetricsServiceBrowserTest.CrashRenderers under ASan. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/metrics/metrics_service_browsertest.cc

diff --git a/chrome/browser/metrics/metrics_service_browsertest.cc b/chrome/browser/metrics/metrics_service_browsertest.cc

index 4243b08a16d579fb370aa12d5f63431d46331a50..f77221c3554d14768e26fce63beb38c68933311a 100644

--- a/chrome/browser/metrics/metrics_service_browsertest.cc

+++ b/chrome/browser/metrics/metrics_service_browsertest.cc

@@ -74,7 +74,9 @@ IN_PROC_BROWSER_TEST_F(MetricsServiceBrowserTest, CloseRenderersNormally) {

}

// Flaky on Linux. See http://crbug.com/131094

-#if defined(OS_LINUX)

+// Child crashes fail the process on ASan (see crbug.com/411251,

+// crbug.com/368525).

+#if defined(OS_LINUX) || defined(ADDRESS_SANITIZER)

#define MAYBE_CrashRenderers DISABLED_CrashRenderers

#else

#define MAYBE_CrashRenderers CrashRenderers

« no previous file with comments | « no previous file | no next file » | no next file with comments »