Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 964393002: Dispatch change events when file changes have happened on Drive. (Closed)

Created:
5 years, 9 months ago by yawano
Modified:
5 years, 9 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dispatch change events when file changes have happened on Drive. BUG=463053 TEST=manually tested as described in the issue. Committed: https://crrev.com/d3f5c0413f79103ce7d03d83387176d550c300ea Cr-Commit-Position: refs/heads/master@{#318835}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix failed test case. #

Total comments: 2

Patch Set 3 : Add null check. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_contents.js View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/main_window_component.js View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_table.js View 1 2 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 14 (2 generated)
yawano
PTAL. Thank you!
5 years, 9 months ago (2015-03-02 09:36:39 UTC) #2
hirono
https://codereview.chromium.org/964393002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js File ui/file_manager/file_manager/foreground/js/directory_contents.js (right): https://codereview.chromium.org/964393002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js#newcode804 ui/file_manager/file_manager/foreground/js/directory_contents.js:804: updatedIndexes.push(i); Index can be changed, because we modify this.fileList ...
5 years, 9 months ago (2015-03-02 09:45:22 UTC) #3
yawano
Thank you for the review! https://codereview.chromium.org/964393002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js File ui/file_manager/file_manager/foreground/js/directory_contents.js (right): https://codereview.chromium.org/964393002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js#newcode804 ui/file_manager/file_manager/foreground/js/directory_contents.js:804: updatedIndexes.push(i); On 2015/03/02 09:45:22, ...
5 years, 9 months ago (2015-03-02 09:54:48 UTC) #4
hirono
LGTM! https://codereview.chromium.org/964393002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js File ui/file_manager/file_manager/foreground/js/directory_contents.js (right): https://codereview.chromium.org/964393002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js#newcode804 ui/file_manager/file_manager/foreground/js/directory_contents.js:804: updatedIndexes.push(i); On 2015/03/02 09:54:48, yawano wrote: > On ...
5 years, 9 months ago (2015-03-02 10:01:59 UTC) #5
yawano
Fixed failed test case. PTAL. Thank you! https://codereview.chromium.org/964393002/diff/20001/ui/file_manager/file_manager/foreground/js/main_window_component.js File ui/file_manager/file_manager/foreground/js/main_window_component.js (right): https://codereview.chromium.org/964393002/diff/20001/ui/file_manager/file_manager/foreground/js/main_window_component.js#newcode285 ui/file_manager/file_manager/foreground/js/main_window_component.js:285: if (item ...
5 years, 9 months ago (2015-03-03 01:55:49 UTC) #6
hirono
https://codereview.chromium.org/964393002/diff/20001/ui/file_manager/file_manager/foreground/js/main_window_component.js File ui/file_manager/file_manager/foreground/js/main_window_component.js (right): https://codereview.chromium.org/964393002/diff/20001/ui/file_manager/file_manager/foreground/js/main_window_component.js#newcode285 ui/file_manager/file_manager/foreground/js/main_window_component.js:285: if (item && !item.hasAttribute('renaming')) { On 2015/03/03 01:55:49, yawano ...
5 years, 9 months ago (2015-03-03 02:17:01 UTC) #7
yawano
Thank you for the catch. I added null check for it. PTAL. https://codereview.chromium.org/964393002/diff/40001/ui/file_manager/file_manager/foreground/js/ui/file_table.js File ui/file_manager/file_manager/foreground/js/ui/file_table.js ...
5 years, 9 months ago (2015-03-03 03:15:54 UTC) #8
hirono
LGTM! Thanks!
5 years, 9 months ago (2015-03-03 03:19:57 UTC) #9
yawano
On 2015/03/03 03:19:57, hirono wrote: > LGTM! Thanks! Thank you!
5 years, 9 months ago (2015-03-03 03:20:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964393002/40001
5 years, 9 months ago (2015-03-03 03:21:14 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-03 03:40:08 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 03:41:06 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d3f5c0413f79103ce7d03d83387176d550c300ea
Cr-Commit-Position: refs/heads/master@{#318835}

Powered by Google App Engine
This is Rietveld 408576698