ui/file_manager/file_manager/foreground/js/main_window_component.js - Issue 964393002: Dispatch change events when file changes have happened on Drive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/main_window_component.js

Issue 964393002: Dispatch change events when file changes have happened on Drive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add null check. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/directory_contents.js ('k') | ui/file_manager/file_manager/foreground/js/ui/file_table.js » ('j') | ui/file_manager/file_manager/foreground/js/ui/file_table.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/main_window_component.js

diff --git a/ui/file_manager/file_manager/foreground/js/main_window_component.js b/ui/file_manager/file_manager/foreground/js/main_window_component.js

index 754d33630a391b391e10ac5976bebb2ba84520f1..1a3369035dbce8fb22f58b4b7fcfdae17a0c46de 100644

--- a/ui/file_manager/file_manager/foreground/js/main_window_component.js

+++ b/ui/file_manager/file_manager/foreground/js/main_window_component.js

@@ -282,7 +282,7 @@ MainWindowComponent.prototype.onListKeyDown_ = function(event) {

selection.indexes[0]);

// If the item is in renaming process, we don't allow to change

// directory.

- if (!item.hasAttribute('renaming')) {

+ if (item && !item.hasAttribute('renaming')) {

event.preventDefault();

this.directoryModel_.changeDirectoryEntry(selection.entries[0]);

}