Issue 964333002: Implement DOMQuad of geometry interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 964333002: Implement DOMQuad of geometry interfaces.

Created:
5 years, 9 months ago by zino

Modified:
5 years, 9 months ago

Reviewers:
philipj_slow

CC:
blink-reviews, arv+blink, vivekg, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Implement DOMQuad of geometry interfaces. The DOMQuad can represent a quadrilateral. The specification: http://dev.w3.org/fxtf/geometry/ Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V_bJNtOg0oM BUG=388780

Patch Set 1 #

Patch Set 2 : add license #

Patch Set 3 : expected #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+591 lines, -5 lines)			Patch
A	LayoutTests/fast/dom/geometry-interfaces-dom-quad.html	View		1 chunk	+210 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/geometry-interfaces-dom-quad-expected.txt	View		1 chunk	+151 lines, -0 lines	0 comments	Download
M	LayoutTests/webexposed/global-interface-listing-expected.txt	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/core.gypi	View	1 2	4 chunks	+6 lines, -0 lines	0 comments	Download
M	Source/core/dom/DOMPoint.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/dom/DOMPointReadOnly.h	View		1 chunk	+1 line, -1 line	0 comments	Download
A	Source/core/dom/DOMQuad.h	View		1 chunk	+73 lines, -0 lines	0 comments	Download
A	Source/core/dom/DOMQuad.cpp	View		1 chunk	+110 lines, -0 lines	0 comments	Download
A	Source/core/dom/DOMQuad.idl	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
A	Source/core/dom/DOMRectInit.idl	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

philipj_slow

5 years, 9 months ago (2015-03-03 05:50:41 UTC) #3

I think this would make most sense if implemented together with getBoxQuads or
another API that needs DOMQuad:
http://dev.w3.org/csswg/cssom-view/#the-geometryutils-interface

Or is there something useful one can do with only the DOMQuad API? I see that
Firefox has it, FWIW.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages