Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 964283002: [Oilpan] Add --js-flags=--expose-gc flag in test (Closed)

Created:
5 years, 9 months ago by peria
Modified:
5 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add --js-flags=--expose-gc flag in OilpanGCTimes test. It enables renderers without DumpRenderTree to trigger Blink GCs. BUG=438074, 420515 Committed: https://crrev.com/aa5cd1665963005154d1e8dfa7e757d35f233d10 Cr-Commit-Position: refs/heads/master@{#318888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/perf/measurements/oilpan_gc_times.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
peria
PTL
5 years, 9 months ago (2015-03-02 05:37:14 UTC) #2
kouhei (in TOK)
lgtm
5 years, 9 months ago (2015-03-02 05:37:33 UTC) #3
haraken
LGTM
5 years, 9 months ago (2015-03-02 05:39:49 UTC) #4
peria
Sami: could you take a look as an owner?
5 years, 9 months ago (2015-03-02 05:41:52 UTC) #5
peria
I was sorry. I forgot to add Sami in reviewers. Sasmi, could you check it?
5 years, 9 months ago (2015-03-03 02:55:16 UTC) #7
Sami
lgtm.
5 years, 9 months ago (2015-03-03 12:12:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964283002/1
5 years, 9 months ago (2015-03-03 14:39:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 16:34:38 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 16:35:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa5cd1665963005154d1e8dfa7e757d35f233d10
Cr-Commit-Position: refs/heads/master@{#318888}

Powered by Google App Engine
This is Rietveld 408576698