tools/gn/loader.h - Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/loader.h

Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix chromium-style plugin errors Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/loader.h

diff --git a/tools/gn/loader.h b/tools/gn/loader.h

index b5f0ad9f6527ff882235483feaae3682b8319090..5a379ecf9a19f773dd04d7bc2cd01704284c3f2f 100644

--- a/tools/gn/loader.h

+++ b/tools/gn/loader.h

@@ -79,7 +79,7 @@ class LoaderImpl : public Loader {

const base::Callback<void(const ParseNode*)>&,

Err*)> AsyncLoadFileCallback;

- LoaderImpl(const BuildSettings* build_settings);

+ explicit LoaderImpl(const BuildSettings* build_settings);

// Loader implementation.

void Load(const SourceFile& file,

« no previous file with comments | « tools/gn/input_file_manager.h ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »