tools/gn/input_file_manager.h - Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/input_file_manager.h

Issue 964203002: tools/gn: Fix errors found by Facebook's flint tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix chromium-style plugin errors Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/input_file_manager.h

diff --git a/tools/gn/input_file_manager.h b/tools/gn/input_file_manager.h

index d8592a02a98fe3445b37a48816ac36c816652aa1..c817c1c31bb9dcb09cf4371ff680011b3f4dc420 100644

--- a/tools/gn/input_file_manager.h

+++ b/tools/gn/input_file_manager.h

@@ -94,7 +94,7 @@ class InputFileManager : public base::RefCountedThreadSafe<InputFileManager> {

friend class base::RefCountedThreadSafe<InputFileManager>;

struct InputFileData {

- InputFileData(const SourceFile& file_name);

+ explicit InputFileData(const SourceFile& file_name);

~InputFileData();

// Don't touch this outside the lock until it's marked loaded.

« no previous file with comments | « tools/gn/input_file.h ('k') | tools/gn/loader.h » ('j') | no next file with comments »