Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 964133002: Document the ClientRect* vs DOMRect* situation (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
zino
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Document the ClientRect* vs DOMRect* situation Add a UseCounter for the ClientRectList.item() method. Adding [MeasureAs=ClientRectListItem] to the existing single line actually only counts the named getter, but split them in the IDL for clarity. Remove the ClientRectList FIXMEs that have been there since the interface was added in 2009: https://trac.webkit.org/changeset/40837 DOMRectList or an array of ClientRect/DOMRect would not throw here, so there's no reason to ever implement the requirements of the old spec. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M Source/core/dom/ClientRect.idl View 2 chunks +8 lines, -1 line 0 comments Download
M Source/core/dom/ClientRectList.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/ClientRectList.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/dom/ClientRectList.idl View 1 chunk +17 lines, -3 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-01 04:11:48 UTC) #2
zino
On 2015/03/01 04:11:48, philipj_UTC7 wrote: > PTAL lgtm
5 years, 9 months ago (2015-03-02 03:58:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/964133002/1
5 years, 9 months ago (2015-03-02 03:59:41 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 04:50:22 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191078

Powered by Google App Engine
This is Rietveld 408576698