Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: Source/core/dom/ClientRectList.cpp

Issue 964133002: Document the ClientRect* vs DOMRect* situation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/ClientRectList.h ('k') | Source/core/dom/ClientRectList.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2009 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 m_list.append(ClientRect::create(quads[i].boundingBox())); 44 m_list.append(ClientRect::create(quads[i].boundingBox()));
45 } 45 }
46 46
47 unsigned ClientRectList::length() const 47 unsigned ClientRectList::length() const
48 { 48 {
49 return m_list.size(); 49 return m_list.size();
50 } 50 }
51 51
52 ClientRect* ClientRectList::item(unsigned index) 52 ClientRect* ClientRectList::item(unsigned index)
53 { 53 {
54 if (index >= m_list.size()) { 54 if (index >= m_list.size())
55 // FIXME: this should throw an exception.
56 // ec = IndexSizeError;
57 return 0; 55 return 0;
58 }
59 56
60 return m_list[index].get(); 57 return m_list[index].get();
61 } 58 }
62 59
63 DEFINE_TRACE(ClientRectList) 60 DEFINE_TRACE(ClientRectList)
64 { 61 {
65 visitor->trace(m_list); 62 visitor->trace(m_list);
66 } 63 }
67 64
68 } // namespace blink 65 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/dom/ClientRectList.h ('k') | Source/core/dom/ClientRectList.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698