Issue 964023002: Remove unused foregroundRect argument to RenderLayerClipper::calculateRects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 964023002: Remove unused foregroundRect argument to RenderLayerClipper::calculateRects. (Closed)

Created:
5 years, 9 months ago by ojan

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium, eseidel

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove unused foregroundRect argument to RenderLayerClipper::calculateRects. The only thing that uses it is RenderTreeAsText. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a8ef883316d78017789bb3fb92afa6ffed57d631

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -45 lines)			Patch
M	sky/engine/core/rendering/RenderBox.cpp	View	2 chunks	+4 lines, -7 lines	0 comments	Download
M	sky/engine/core/rendering/RenderLayerClipper.h	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	sky/engine/core/rendering/RenderLayerClipper.cpp	View	5 chunks	+3 lines, -23 lines	1 comment	Download
M	sky/engine/core/rendering/RenderTreeAsText.cpp	View	4 chunks	+4 lines, -7 lines	0 comments	Download
M	sky/tests/layout/ellipsis-expected.txt	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ojan

https://codereview.chromium.org/964023002/diff/1/sky/engine/core/rendering/RenderLayerClipper.cpp File sky/engine/core/rendering/RenderLayerClipper.cpp (left): https://codereview.chromium.org/964023002/diff/1/sky/engine/core/rendering/RenderLayerClipper.cpp#oldcode158 sky/engine/core/rendering/RenderLayerClipper.cpp:158: LayoutRect RenderLayerClipper::childrenClipRect() const This was just dead code.

5 years, 9 months ago (2015-02-28 01:55:25 UTC) #2

ojan

5 years, 9 months ago (2015-03-02 20:10:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a8ef883316d78017789bb3fb92afa6ffed57d631 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages