Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: sky/engine/core/rendering/RenderTreeAsText.cpp

Issue 964023002: Remove unused foregroundRect argument to RenderLayerClipper::calculateRects. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/RenderTreeAsText.cpp
diff --git a/sky/engine/core/rendering/RenderTreeAsText.cpp b/sky/engine/core/rendering/RenderTreeAsText.cpp
index 4b12bf75f55c9d35ef548da92a0982ce3e6a7b82..1ac5481ede10b150830b443774a377cb5cfb37ea 100644
--- a/sky/engine/core/rendering/RenderTreeAsText.cpp
+++ b/sky/engine/core/rendering/RenderTreeAsText.cpp
@@ -334,12 +334,11 @@ void write(TextStream& ts, const RenderObject& o, int indent, RenderAsTextBehavi
}
static void write(TextStream& ts, RenderLayer& l,
- const LayoutRect& layerBounds, const LayoutRect& backgroundClipRect, const LayoutRect& clipRect,
+ const LayoutRect& layerBounds, const LayoutRect& backgroundClipRect,
int indent = 0, RenderAsTextBehavior behavior = RenderAsTextBehaviorNormal)
{
IntRect adjustedLayoutBounds = pixelSnappedIntRect(layerBounds);
IntRect adjustedBackgroundClipRect = pixelSnappedIntRect(backgroundClipRect);
- IntRect adjustedClipRect = pixelSnappedIntRect(clipRect);
writeIndent(ts, indent);
@@ -353,8 +352,6 @@ static void write(TextStream& ts, RenderLayer& l,
if (!adjustedLayoutBounds.isEmpty()) {
if (!adjustedBackgroundClipRect.contains(adjustedLayoutBounds))
ts << " backgroundClip " << adjustedBackgroundClipRect;
- if (!adjustedClipRect.contains(adjustedLayoutBounds))
- ts << " clip " << adjustedClipRect;
}
ts << "\n";
@@ -373,8 +370,8 @@ void RenderTreeAsText::writeLayers(TextStream& ts, const RenderLayer* rootLayer,
// Calculate the clip rects we should use.
LayoutRect layerBounds;
- ClipRect damageRect, clipRectToApply;
- layer->clipper().calculateRects(ClipRectsContext(rootLayer, UncachedClipRects), paintDirtyRect, layerBounds, damageRect, clipRectToApply);
+ ClipRect damageRect;
+ layer->clipper().calculateRects(ClipRectsContext(rootLayer, UncachedClipRects), paintDirtyRect, layerBounds, damageRect);
// FIXME: Apply overflow to the root layer to not break every test. Complete hack. Sigh.
if (rootLayer == layer)
@@ -386,7 +383,7 @@ void RenderTreeAsText::writeLayers(TextStream& ts, const RenderLayer* rootLayer,
bool shouldPaint = (behavior & RenderAsTextShowAllLayers) ? true : layer->intersectsDamageRect(layerBounds, damageRect.rect(), rootLayer);
if (shouldPaint)
- write(ts, *layer, layerBounds, damageRect.rect(), clipRectToApply.rect(), indent, behavior);
+ write(ts, *layer, layerBounds, damageRect.rect(), indent, behavior);
if (Vector<RenderLayerStackingNode*>* normalFlowList = layer->stackingNode()->normalFlowList()) {
int currIndent = indent;

Powered by Google App Engine
This is Rietveld 408576698