Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 963983003: Remove [TypeChecking=Unrestricted] use in Source/modules/ (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com, philipj_slow, timvolodine, Raymond Toy, mvanouwerkerk+watch_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove [TypeChecking=Unrestricted] use in Source/modules/ The IDL compiler has been updated to always generate code that rejects non-finite numbers, so removing [TypeChecking=Unrestricted] does not change generated code. BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -27 lines) Patch
M Source/modules/battery/BatteryManager.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceMotionEvent.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/device_orientation/DeviceOrientationEvent.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/geofencing/CircularGeofencingRegionInit.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/mediasource/MediaSource.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBuffer.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechGrammar.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechGrammarList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AnalyserNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioBufferSourceNode.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioContext.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioListener.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioParam.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/OfflineAudioContext.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/OscillatorNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/PannerNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webmidi/MIDIMessageEventInit.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/webmidi/MIDIOutput.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL
5 years, 9 months ago (2015-03-02 15:43:07 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-02 15:44:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963983003/1
5 years, 9 months ago (2015-03-02 15:45:51 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 17:06:09 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191117

Powered by Google App Engine
This is Rietveld 408576698