Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 963823003: Move InMemoryURLIndex into chrome/browser/autocomplete (Closed)

Created:
5 years, 9 months ago by sdefresne
Modified:
5 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, browser-components-watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@shortcut-database
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move InMemoryURLIndex into chrome/browser/autocomplete InMemoryURLIndex is not used in the history code (except for the creation) but only by the autocomplete code, so move the code there and all its related types. BUG=453790 Committed: https://crrev.com/039209fcd5598340b3c3b02d98f5453013953cad Cr-Commit-Position: refs/heads/master@{#319634}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix gn BUILD #

Patch Set 3 : Fix typo #

Patch Set 4 : Rebase #

Patch Set 5 : Fix gn BUILD #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Patch Set 9 : Fixing win_chromium_x64_rel_ng build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -4518 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 7 8 2 chunks +1 line, -1 line 0 comments Download
A chrome/browser/autocomplete/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/history_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 2 3 4 5 6 7 8 2 chunks +1 line, -1 line 0 comments Download
A + chrome/browser/autocomplete/in_memory_url_index.h View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/autocomplete/in_memory_url_index.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/autocomplete/in_memory_url_index_cache.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/autocomplete/in_memory_url_index_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/autocomplete/in_memory_url_index_types.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/autocomplete/in_memory_url_index_types_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/autocomplete/in_memory_url_index_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/autocomplete/scored_history_match.h View 3 chunks +7 lines, -4 lines 0 comments Download
A + chrome/browser/autocomplete/scored_history_match.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/scored_history_match_builder_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/autocomplete/url_index_private_data.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/autocomplete/url_index_private_data.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/DEPS View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/history/history_service.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/history/in_memory_url_index.h View 1 chunk +0 lines, -306 lines 0 comments Download
D chrome/browser/history/in_memory_url_index.cc View 1 chunk +0 lines, -333 lines 0 comments Download
D chrome/browser/history/in_memory_url_index_unittest.cc View 1 chunk +0 lines, -1262 lines 0 comments Download
D chrome/browser/history/url_index_private_data.h View 1 chunk +0 lines, -394 lines 0 comments Download
D chrome/browser/history/url_index_private_data.cc View 1 chunk +0 lines, -1350 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 5 chunks +22 lines, -4 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/base/history_index_restore_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -1 line 0 comments Download
M components/history.gypi View 3 chunks +0 lines, -20 lines 0 comments Download
M components/history/core/browser/BUILD.gn View 1 2 3 4 3 chunks +0 lines, -12 lines 0 comments Download
M components/history/core/browser/download_database.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M components/history/core/browser/history_database.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -2 lines 0 comments Download
D components/history/core/browser/in_memory_url_index_cache.proto View 1 chunk +0 lines, -103 lines 0 comments Download
D components/history/core/browser/in_memory_url_index_types.h View 1 chunk +0 lines, -179 lines 0 comments Download
D components/history/core/browser/in_memory_url_index_types.cc View 1 chunk +0 lines, -163 lines 0 comments Download
D components/history/core/browser/in_memory_url_index_types_unittest.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D components/history/core/browser/scored_history_match.h View 1 chunk +0 lines, -108 lines 0 comments Download
D components/history/core/browser/scored_history_match.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M components/history/core/browser/thumbnail_database.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -3 lines 0 comments Download
M components/history/core/browser/top_sites_database.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/url_utils.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/visit_filter.cc View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
sdefresne
I think this class (and supporting code) does not belongs into the history code but ...
5 years, 9 months ago (2015-02-27 18:35:25 UTC) #2
Mark P
lgtm https://codereview.chromium.org/963823003/diff/1/chrome/browser/history/DEPS File chrome/browser/history/DEPS (left): https://codereview.chromium.org/963823003/diff/1/chrome/browser/history/DEPS#oldcode30 chrome/browser/history/DEPS:30: "!components/bookmarks/browser/bookmark_utils.h", This isn't a consequence of this change, ...
5 years, 9 months ago (2015-02-27 20:39:12 UTC) #3
sdefresne
Thank you for the review. https://codereview.chromium.org/963823003/diff/1/chrome/browser/history/DEPS File chrome/browser/history/DEPS (left): https://codereview.chromium.org/963823003/diff/1/chrome/browser/history/DEPS#oldcode30 chrome/browser/history/DEPS:30: "!components/bookmarks/browser/bookmark_utils.h", On 2015/02/27 20:39:12, ...
5 years, 9 months ago (2015-03-02 08:53:03 UTC) #4
sdefresne
jcivelli: (will TBR) OWNERS for chrome/test/base/history_index_restore_observer.h sky: OWNERS for chrome/browser/BUILD.gn chrome/browser/autocomplete/BUILD.gn chrome/browser/chromeos/BUILD.gn chrome/browser/extensions/BUILD.gn chrome/browser/ui/BUILD.gn
5 years, 9 months ago (2015-03-02 15:00:03 UTC) #6
Jay Civelli
LGTM for chrome/test
5 years, 9 months ago (2015-03-02 16:49:48 UTC) #7
sky
sky->brettw
5 years, 9 months ago (2015-03-02 18:09:40 UTC) #9
sdefresne
brettw: ping for BUILD.gn OWNERS
5 years, 9 months ago (2015-03-04 15:56:28 UTC) #10
sdefresne
brettw: please review the following files only chrome/browser/BUILD.gn chrome/browser/autocomplete/BUILD.gn chrome/browser/chromeos/BUILD.gn chrome/browser/extensions/BUILD.gn chrome/browser/ui/BUILD.gn If you do ...
5 years, 9 months ago (2015-03-05 10:52:12 UTC) #11
sdefresne
-brettw who appears to be unavailable +jhawkins can you review chrome/browser/BUILD.gn chrome/browser/chromeos/BUILD.gn chrome/browser/extensions/BUILD.gn chrome/browser/ui/BUILD.gn as ...
5 years, 9 months ago (2015-03-06 09:05:36 UTC) #13
sky
LGTM
5 years, 9 months ago (2015-03-06 17:49:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963823003/260001
5 years, 9 months ago (2015-03-09 15:17:21 UTC) #23
commit-bot: I haz the power
Committed patchset #9 (id:260001)
5 years, 9 months ago (2015-03-09 15:33:29 UTC) #24
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 15:34:21 UTC) #25
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/039209fcd5598340b3c3b02d98f5453013953cad
Cr-Commit-Position: refs/heads/master@{#319634}

Powered by Google App Engine
This is Rietveld 408576698