Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 include_rules = [ | 1 include_rules = [ |
| 2 # History is being made into a Browser Component (http://crbug.com/370850), so | 2 # History is being made into a Browser Component (http://crbug.com/370850), so |
| 3 # we have these basic rules followed by temporary exceptions. Please don't | 3 # we have these basic rules followed by temporary exceptions. Please don't |
| 4 # add to the list of exceptions! | 4 # add to the list of exceptions! |
| 5 # | 5 # |
| 6 # Please send reviews to sdefresne@chromium.org when adding dependencies to | 6 # Please send reviews to sdefresne@chromium.org when adding dependencies to |
| 7 # this list. | 7 # this list. |
| 8 "-chrome/browser", | 8 "-chrome/browser", |
| 9 "-components", | 9 "-components", |
| 10 | 10 |
| 11 "+chrome/browser/history", | 11 "+chrome/browser/history", |
| 12 "+components/history", | 12 "+components/history", |
| 13 "+components/favicon_base", | 13 "+components/favicon_base", |
| 14 "+components/keyed_service/core", | 14 "+components/keyed_service/core", |
| 15 "+components/signin/core/browser", | 15 "+components/signin/core/browser", |
| 16 | 16 |
| 17 # TODO(sdefresne): Bring this list to zero. | 17 # TODO(sdefresne): Bring this list to zero. |
| 18 # | 18 # |
| 19 # Do not add to the list of temporarily-allowed dependencies below, | 19 # Do not add to the list of temporarily-allowed dependencies below, |
| 20 # and please do not introduce more #includes of these files. | 20 # and please do not introduce more #includes of these files. |
| 21 "!chrome/browser/autocomplete/in_memory_url_index.h", | |
| 21 "!chrome/browser/chrome_notification_types.h", | 22 "!chrome/browser/chrome_notification_types.h", |
| 22 "!chrome/browser/prerender/prerender_contents.h", | 23 "!chrome/browser/prerender/prerender_contents.h", |
| 23 "!chrome/browser/prerender/prerender_manager.h", | 24 "!chrome/browser/prerender/prerender_manager.h", |
| 24 "!chrome/browser/prerender/prerender_manager_factory.h", | 25 "!chrome/browser/prerender/prerender_manager_factory.h", |
| 25 "!chrome/browser/profiles/incognito_helpers.h", | 26 "!chrome/browser/profiles/incognito_helpers.h", |
| 26 "!chrome/browser/profiles/profile.h", | 27 "!chrome/browser/profiles/profile.h", |
| 27 "!chrome/browser/profiles/profile_manager.h", | 28 "!chrome/browser/profiles/profile_manager.h", |
| 28 "!chrome/browser/ui/browser.h", | 29 "!chrome/browser/ui/browser.h", |
| 29 "!chrome/browser/ui/browser_finder.h", | 30 "!chrome/browser/ui/browser_finder.h", |
| 30 "!components/bookmarks/browser/bookmark_utils.h", | |
|
Mark P
2015/02/27 20:39:12
This isn't a consequence of this change, right? I
sdefresne
2015/03/02 08:53:03
Yes, it was a consequence of introducing ScoredHis
| |
| 31 "!components/dom_distiller/core/url_constants.h", | 31 "!components/dom_distiller/core/url_constants.h", |
| 32 ] | 32 ] |
| 33 | 33 |
| 34 specific_include_rules = { | 34 specific_include_rules = { |
| 35 # Browser tests, by definition, need access to the browser objects. | 35 # Browser tests, by definition, need access to the browser objects. |
| 36 '.*_(api|browser|)test\.cc': [ | 36 '.*_(api|browser|)test\.cc': [ |
| 37 "+chrome/browser", | 37 "+chrome/browser", |
| 38 ], | 38 ], |
| 39 # chrome_.* and .*_factory won't be componentized as they belong to the | 39 # chrome_.* and .*_factory won't be componentized as they belong to the |
| 40 # embedder, so they can depend on other feature in chrome/. Same thing | 40 # embedder, so they can depend on other feature in chrome/. Same thing |
| (...skipping 24 matching lines...) Expand all Loading... | |
| 65 "!chrome/browser/autocomplete/scored_history_match_builder_impl.h", | 65 "!chrome/browser/autocomplete/scored_history_match_builder_impl.h", |
| 66 "!chrome/browser/bookmarks/bookmark_model_factory.h", | 66 "!chrome/browser/bookmarks/bookmark_model_factory.h", |
| 67 "!chrome/browser/signin/profile_oauth2_token_service_factory.h", | 67 "!chrome/browser/signin/profile_oauth2_token_service_factory.h", |
| 68 "!chrome/browser/signin/signin_manager_factory.h", | 68 "!chrome/browser/signin/signin_manager_factory.h", |
| 69 "!chrome/browser/sync/profile_sync_service.h", | 69 "!chrome/browser/sync/profile_sync_service.h", |
| 70 "!chrome/browser/sync/profile_sync_service_factory.h", | 70 "!chrome/browser/sync/profile_sync_service_factory.h", |
| 71 "!chrome/browser/sync/profile_sync_service_mock.h", | 71 "!chrome/browser/sync/profile_sync_service_mock.h", |
| 72 "!components/bookmarks/test/bookmark_test_helpers.h", | 72 "!components/bookmarks/test/bookmark_test_helpers.h", |
| 73 ] | 73 ] |
| 74 } | 74 } |
| OLD | NEW |