Issue 963603002: Revert of MIPS: Also skip when the target is the global object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 963603002: Revert of MIPS: Also skip when the target is the global object. (Closed)

Created:
5 years, 9 months ago by Michael Achenbach

Modified:
5 years, 9 months ago

Reviewers:
balazs.kilvady, dusmil.imgtec, danno, Toon Verwaest, akos.palfi.imgtec, gergely.kis.imgtec, paul.l...

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of MIPS: Also skip when the target is the global object. (patchset #1 id:1 of https://codereview.chromium.org/957413002/) Reason for revert: Need to revert the ported CL. Original issue's description: > MIPS: Also skip when the target is the global object. > > Port cc918d30b9d586ce974b71232473f2ae3c5e7847 > > BUG= > > Committed: https://crrev.com/b24a0efa447235e11b9ff9d1eeaada06131b2e04 > Cr-Commit-Position: refs/heads/master@{#26897} TBR=danno@chromium.org,verwaest@chromium.org,paul.lind@imgtec.com,gergely.kis@imgtec.com,akos.palfi@imgtec.com,dusan.milosavljevic@imgtec.com,balazs.kilvady@imgtec.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/da710f958812bd203171e917da584b3adf67dc71 Cr-Commit-Position: refs/heads/master@{#26898}

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	src/ic/mips/handler-compiler-mips.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	src/ic/mips64/handler-compiler-mips64.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Michael Achenbach

Created Revert of MIPS: Also skip when the target is the global object.

5 years, 9 months ago (2015-02-26 21:00:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963603002/1

5 years, 9 months ago (2015-02-26 21:01:49 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-02-26 21:02:21 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/da710f958812bd203171e917da584b3adf67dc71
Cr-Commit-Position: refs/heads/master@{#26898}