Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: src/ic/mips/handler-compiler-mips.cc

Issue 963603002: Revert of MIPS: Also skip when the target is the global object. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 466 matching lines...) Expand 10 before | Expand all | Expand 10 after
477 } 477 }
478 478
479 // Go to the next object in the prototype chain. 479 // Go to the next object in the prototype chain.
480 current = prototype; 480 current = prototype;
481 current_map = handle(current->map()); 481 current_map = handle(current->map());
482 } 482 }
483 483
484 // Log the check depth. 484 // Log the check depth.
485 LOG(isolate(), IntEvent("check-maps-depth", depth + 1)); 485 LOG(isolate(), IntEvent("check-maps-depth", depth + 1));
486 486
487 if (!current_map->IsJSGlobalObjectMap() && 487 if (depth != 0 || check == CHECK_ALL_MAPS) {
488 (depth != 0 || check == CHECK_ALL_MAPS)) {
489 // Check the holder map. 488 // Check the holder map.
490 __ lw(scratch1, FieldMemOperand(reg, HeapObject::kMapOffset)); 489 __ lw(scratch1, FieldMemOperand(reg, HeapObject::kMapOffset));
491 Handle<WeakCell> cell = Map::WeakCellForMap(current_map); 490 Handle<WeakCell> cell = Map::WeakCellForMap(current_map);
492 __ GetWeakValue(scratch2, cell); 491 __ GetWeakValue(scratch2, cell);
493 __ Branch(miss, ne, scratch2, Operand(scratch1)); 492 __ Branch(miss, ne, scratch2, Operand(scratch1));
494 } 493 }
495 494
496 // Perform security check for access to the global object. 495 // Perform security check for access to the global object.
497 DCHECK(current_map->IsJSGlobalProxyMap() || 496 DCHECK(current_map->IsJSGlobalProxyMap() ||
498 !current_map->is_access_check_needed()); 497 !current_map->is_access_check_needed());
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
743 // Return the generated code. 742 // Return the generated code.
744 return GetCode(kind(), Code::NORMAL, name); 743 return GetCode(kind(), Code::NORMAL, name);
745 } 744 }
746 745
747 746
748 #undef __ 747 #undef __
749 } 748 }
750 } // namespace v8::internal 749 } // namespace v8::internal
751 750
752 #endif // V8_TARGET_ARCH_MIPS 751 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « no previous file | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698