Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/telemetry/telemetry/value/histogram.py

Issue 963313002: [Telemetry] Add interaction_record field to Value (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: misc typo fixes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/histogram.py
diff --git a/tools/telemetry/telemetry/value/histogram.py b/tools/telemetry/telemetry/value/histogram.py
index 877e135e5403af2024720cd9f51f2d6f90dce7c3..6f5d4067c8c7766b2fca483f056bcd3f54656853 100644
--- a/tools/telemetry/telemetry/value/histogram.py
+++ b/tools/telemetry/telemetry/value/histogram.py
@@ -29,9 +29,9 @@ class HistogramValueBucket(object):
class HistogramValue(value_module.Value):
def __init__(self, page, name, units,
raw_value=None, raw_value_json=None, important=True,
- description=None):
+ description=None, interaction_record=None):
super(HistogramValue, self).__init__(page, name, units, important,
- description)
+ description, interaction_record)
if raw_value_json:
assert raw_value == None, \
'Don\'t specify both raw_value and raw_value_json'
@@ -52,12 +52,13 @@ class HistogramValue(value_module.Value):
else:
page_name = None
return ('HistogramValue(%s, %s, %s, raw_json_string="%s", '
- 'important=%s, description=%s') % (
- page_name,
- self.name, self.units,
- self.ToJSONString(),
- self.important,
- self.description)
+ 'important=%s, description=%s, interaction_record=%s') % (
+ page_name,
+ self.name, self.units,
+ self.ToJSONString(),
+ self.important,
+ self.description,
+ self.interaction_record)
def GetBuildbotDataType(self, output_context):
if self._IsImportantGivenOutputIntent(output_context):
@@ -103,6 +104,9 @@ class HistogramValue(value_module.Value):
kwargs = value_module.Value.GetConstructorKwArgs(value_dict, page_dict)
kwargs['raw_value'] = value_dict
+ if 'interaction_record' in value_dict:
+ kwargs['interaction_record'] = value_dict['interaction_record']
+
return HistogramValue(**kwargs)
@classmethod
@@ -113,7 +117,7 @@ class HistogramValue(value_module.Value):
v0.page, v0.name, v0.units,
raw_value_json=histogram_util.AddHistograms(
[v.ToJSONString() for v in values]),
- important=v0.important)
+ important=v0.important, interaction_record=v0.interaction_record)
@classmethod
def MergeLikeValuesFromDifferentPages(cls, values,
« no previous file with comments | « tools/telemetry/telemetry/value/failure.py ('k') | tools/telemetry/telemetry/value/list_of_scalar_values.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698