Run scripts which don't have any compile targets if any source files change.

scripts/slave/recipes/chromium_trybot.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from infra.libs.infra_types import freeze
 
 DEPS = [
   'bot_update',
   'chromium',
   'chromium_android',
@@ skipping 266 matching lines @@
   return result
 
 
 def all_compile_targets(api, tests):
   """Returns the compile_targets for all the Tests in |tests|."""
   return sorted(set(x
                     for test in tests
                     for x in test.compile_targets(api)))
 
 
+def is_source_file(api, file):
+  """Returns true iff the file is a source file."""
+  _, ext = api.path.splitext(file)
+  return ext in [".cc", ".cpp", ".h", ".java", ".mm"]
+
+
 def _GenStepsInternal(api):
   def get_bot_config(mastername, buildername):
     master_dict = BUILDERS.get(mastername, {})
     return master_dict.get('builders', {}).get(buildername)
 
   mastername = api.properties.get('mastername')
   buildername = api.properties.get('buildername')
   bot_config = get_bot_config(mastername, buildername)
   api.chromium_tests.configure_swarming('chromium', precommit=True)
 
@@ skipping 55 matching lines @@
           override_bot_type='builder_tester',
           override_tests=tests)
 
   requires_compile, _, compile_targets = \
       api.chromium_tests.analyze(
           affected_files,
           all_compile_targets(api, tests + tests_including_triggered),
           compile_targets,
           'trybot_analyze_config.json')
 
-  if not requires_compile:
-    return
+  if requires_compile:
+    tests = tests_in_compile_targets(api, compile_targets, tests)
+    tests_including_triggered = tests_in_compile_targets(
+        api, compile_targets, tests_including_triggered)
 
-  tests = tests_in_compile_targets(api, compile_targets, tests)
-  tests_including_triggered = tests_in_compile_targets(
-      api, compile_targets, tests_including_triggered)
-
-  api.chromium_tests.compile_specific_targets(
-      bot_config['mastername'],
-      bot_config['buildername'],
-      bot_update_step,
-      master_dict,
-      test_spec,
-      compile_targets,
-      tests_including_triggered,
-      override_bot_type='builder_tester')
+    api.chromium_tests.compile_specific_targets(
+        bot_config['mastername'],
+        bot_config['buildername'],
+        bot_update_step,
+        master_dict,
+        test_spec,
+        compile_targets,
+        tests_including_triggered,
+        override_bot_type='builder_tester')
+  else:
+    # Even though the patch doesn't require compile on this platform, we'd still
+    # like to run tests not depending on compiled targets (that's obviously not
+    # covered by the "analyze" step) if any source files change.
+    if any([is_source_file(api, f) for f in affected_files]):
+      tests = [t for t in tests if not t.compile_targets(api)]
+    else:
+      return

[luqui, 2015/03/02 23:21:53]

You could either add a test for it in GenTests (get affected_files to be empty
somehow) or add # pragma: no cover.  The former is preferable, of course, if you
can figure out how.

[jam, 2015/03/04 15:16:41]

right, i didn't know how to do the "somehow" part :)

[luqui, 2015/03/04 21:51:04]

You could try 

   yield (api.test('...') + 
          ... +
          api.override_step_data('git diff to analyze patch',
api.raw_io.stream_output('')))

I'm not super familiar with this, but that's my best guess.

 
   def deapply_patch_fn(failing_tests):
     api.chromium_tests.deapply_patch(bot_update_step)
     compile_targets = list(api.itertools.chain(
         *[t.compile_targets(api) for t in failing_tests]))
     if compile_targets:
       # Remove duplicate targets.
       compile_targets = sorted(set(compile_targets))
       has_failing_swarming_tests = [
           t for t in failing_tests if t.uses_swarming]
@@ skipping 500 matching lines @@
                      tryserver=True)
   yield step_failure(mastername='tryserver.chromium.linux',
                      buildername='android_clang_dbg_recipe',
                      steps=['findbugs (with patch)'],
                      tryserver=True)
   yield step_failure(mastername='tryserver.chromium.linux',
                      buildername='android_clang_dbg_recipe',
                      steps=['findbugs (with patch)',
                             'findbugs (without patch)'],
                      tryserver=True)