Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 963093003: Clean up the top level BUILD.gn file. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
brettw, eroman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up the top level BUILD.gn file. There was a bunch of todo-related stuff that could be cleaned up, and this change also removes the 'gyp_all' target which was mostly just duplicating stuff in all.gyp. This CL should have no actual affect on the builds, apart from deleting the one target, but is also a prelude to subsequent CLs for this bug. R=brettw@chromium.org BUG=461019 Committed: https://crrev.com/18e5743bbe39f30b75abad4c5c7f0efab288ed9a Cr-Commit-Position: refs/heads/master@{#318523}

Patch Set 1 #

Patch Set 2 : delete stray lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -54 lines) Patch
M BUILD.gn View 3 chunks +18 lines, -54 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Dirk Pranke
5 years, 9 months ago (2015-02-27 19:59:25 UTC) #1
brettw
lgtm
5 years, 9 months ago (2015-02-27 20:57:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963093003/20001
5 years, 9 months ago (2015-02-27 21:13:55 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-27 21:46:53 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/18e5743bbe39f30b75abad4c5c7f0efab288ed9a Cr-Commit-Position: refs/heads/master@{#318523}
5 years, 9 months ago (2015-02-27 21:48:11 UTC) #6
eroman
Looks like this caused a break on mac: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20%28dbg%29/builds/5233/steps/gn/logs/stdio
5 years, 9 months ago (2015-02-27 22:03:54 UTC) #8
eroman
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/962383002/ by eroman@chromium.org. ...
5 years, 9 months ago (2015-02-27 22:05:07 UTC) #9
Dirk Pranke
5 years, 9 months ago (2015-02-27 22:05:53 UTC) #10
Message was sent while issue was closed.
On 2015/02/27 22:05:07, eroman wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/962383002/ by mailto:eroman@chromium.org.
> 
> The reason for reverting is: 
> ERROR at //BUILD.gn:246:7: Item not found
>       "//third_party/usrsctp",  # TODO(GYP)
>       ^----------------------
> You were trying to remove "//third_party/usrsctp".

Hrm. Guess I missed that part. Thanks for catching it!

Powered by Google App Engine
This is Rietveld 408576698