Clean up the top level BUILD.gn file.

BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This is the root build file for GN. GN will start processing by loading this
 # file, and recursively load all dependencies until all dependencies are either
 # resolved or known not to exist (which will cause the build to fail). So if
 # you add a new build file, there must be some path of dependencies from this
 # file to your new one or GN won't know about it.
 
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 
 if (is_android) {
   import("//build/config/android/config.gni")
 }
 
 declare_args() {
   # A list of extra dependencies to add to the root target. This allows a
   # checkout to add additional targets without explicitly changing any checked-
   # in files.
   root_extra_deps = []
 }
 
-group("gyp_all") {
-  testonly = true
+# The "gn_all" target should list every root target (target that
+# nothing else depends on) built by both GN and GYP. One should
+# be able to run 'ninja gn_all gn_only gn_groups' and then run
+# 'ninja' a second time and have the second ninja invocation do nothing.
+#
+# In addition, the "gn_all" target serves to pull in all of the other
+# build files needed for the build.
+#
+# TODO(GYP): make sure that the above is true and there are scripts run
+# on the bots that enforce this.
 
-  # TODO(GYP): This target should describe everything that is built by a GYP
-  # build but not yet by a GN build, i.e., these are the targets that still
-  # need to be ported to GN. Eventually this target should be identical to
-  # gn_all.
-
-  deps = [
-    ":gn_all",
-    # "//chrome/test:chromedriver_unittests", # TODO(GYP)
-    # "//components:components_browsertests", # TODO(GYP)
-    # "//components/nacl:nacl_loader_unittests", # TODO(GYP)
-    # "//google_apis:google_apis_unittests", # TODO(GYP)
-    # "//ui/compositor:compositor_unittests", # TODO(GYP)
-    # "//device:device_unittests", # TODO(GYP)
-    # "//ppapi:ppapi_unittests", # TODO(GYP)
-    # "//remoting:remoting_unittests",  # TODO(GYP)
-  ]
-}
-
-# The "gn_all" target matches the "gn_all" target in build/all.gyp.
-# It is not (yet!) the same as building "all".
-# TODO(GYP): Make it be basically the same as building all, or at least
-# be sure that we don't want any of the stuff listed in gn_all to
-# be built by default.
-
-# In GN, a "group" is a dummy target that just lists other targets.
 group("gn_all") {
   testonly = true
 
   deps = [
     "//base:base_unittests",
     "//cc:cc_unittests",
     "//chrome",
     "//chrome/test:browser_tests",
     "//chrome/test:interactive_ui_tests",
     "//chrome/test:sync_integration_tests",
     "//chrome/test:unit_tests",
     "//components:components_unittests",
     "//content/shell:content_shell",
     "//content/test:content_browsertests",
     "//content/test:content_perftests",
     "//content/test:content_unittests",
     "//crypto:crypto_unittests",
     "//extensions:extensions_browsertests",
     "//extensions:extensions_unittests",
     "//google_apis/gcm:gcm_unit_tests",
     "//gpu:gpu_unittests",
     "//ipc:ipc_tests",
     "//ipc/mojo:ipc_mojo_unittests",
     "//jingle:jingle_unittests",
     "//media:media_unittests",
-    "//media/mojo",  # only builds in mojo
     "//media/cast:cast_unittests",
     "//mojo",
     "//mojo/common:mojo_common_unittests",
-
-    # "//mojo/services/html_viewer:tests",  # TODO(GYP): Do we need this?
     "//net:net_unittests",
     "//ppapi/examples",  # TODO(GYP): What's the GYP equivalent?
     "//printing:printing_unittests",
     "//skia:skia_unittests",
     "//sql:sql_unittests",
     "//sync:sync_unit_tests",
-
-    # TODO(GYP): the Blink test targets should be public, but
-    # currently aren't. all_blink pulls them in, though.
-    # "//third_party/WebKit/Source/platform:heap_unittests",
-    # "//third_party/WebKit/Source/platform:platform_unittests",
-    # "//third_party/WebKit/Source/wtf:wtf_unittests",
-    "//third_party/WebKit/public:all_blink",
+    "//third_party/WebKit/public:blink_tests",
     "//third_party/cacheinvalidation:cacheinvalidation_unittests",
-
-    # TODO(GYP): This is needed only w/ cld_version==1. What configs set that?
-    "//third_party/cld",
     "//third_party/codesighs",
-
-    # TODO(GYP): This is needed only w/ use_system_fontconfig==0.
-    # What configs set that?
-    # "//third_party/fontconfig",
-
-    # TODO(GYP): This will be pulled in automatically when enable_webrtc==true.
-    # For now pull it in manually so that it doesn't regress.
-    "//third_party/libsrtp",
     "//third_party/mojo/src/mojo/edk/system:mojo_system_unittests",
     "//third_party/mojo/src/mojo/edk/test:mojo_public_bindings_unittests",
     "//third_party/mojo/src/mojo/edk/test:mojo_public_environment_unittests",
     "//third_party/mojo/src/mojo/edk/test:mojo_public_system_unittests",
     "//third_party/mojo/src/mojo/edk/test:mojo_public_utility_unittests",
     "//third_party/pdfium/samples:pdfium_test",
-
-    # TODO(GYP): Verify that this is no longer needed.
     "//third_party/smhasher:pmurhash",
-
-    # TODO(GYP): This will be pulled in automatically when enable_webrtc==true.
-    # For now pull it in manually so that it doesn't regress.
-    "//third_party/usrsctp",
     "//tools/imagediff($host_toolchain)",
     "//tools/gn",
     "//tools/gn:gn_unittests",
     "//tools/telemetry:bitmaptools($host_toolchain)",
     "//ui/accessibility:accessibility_unittests",
     "//ui/app_list:app_list_unittests",
     "//ui/base:ui_base_unittests",
     "//ui/display:display_unittests",
     "//ui/events:events_unittests",
     "//ui/gfx:gfx_unittests",
@@ skipping 159 matching lines @@
     ]
   } else if (is_win) {
     deps += [ "//ui/metro_viewer" ]
     deps -= [
       "//crypto:crypto_unittests",  # TODO(GYP)
       "//net:net_unittests",  # TODO(GYP)
     ]
   }
 }
 
+group("gn_only") {
+  deps = [
+    "//media/mojo",
+    # "//mojo/services/html_viewer:tests",  # TODO(GYP): Do we need this?
+  ]
+}
+
 if (is_linux) {
   # This group corresponds to the list of tests run on the waterfall for
   # desktop Linux GYP builds from testing/buildbot/chromium.linux.json. It's
   # here to help track GYP -> GN conversion progress.
   group("linux_default_tests") {
     testonly = true
     deps = [
       # chromedriver_unittests  TODO(GYP)
       # components_browsertests  TODO(GYP)
       # device_unittests  TODO(GYP)
@@ skipping 46 matching lines @@
       "//ui/touch_selection:ui_touch_selection_unittests",  # PASSES 2/25/2015
       "//ui/views:views_unittests",  # PASSES (*) 2/25/2015
       "//ui/wm:wm_unittests",  # PASSES 2/25/2015
       "//url:url_unittests",  # PASSES 2/25/2015
 
       # Note:
       # (*) Fails but failures match GYP build at time of testing.
     ]
   }
 }