Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Unified Diff: tools/telemetry/telemetry/user_story/user_story_runner_unittest.py

Issue 962793004: [Telemetry] Make "discard_first_result" apply to user_stories too. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/user_story/user_story_runner.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
diff --git a/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py b/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
index 6c5b8a65204cc122e635f7cb2515e558b9167734..7136fd1583464c3e6685c75b077b9e1ed604dc90 100644
--- a/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
+++ b/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
@@ -355,61 +355,6 @@ class UserStoryRunnerTest(unittest.TestCase):
# The AppCrashException gets added as a failure.
self.assertEquals(1, len(self.results.failures))
- def testDiscardFirstResult(self):
- us = user_story_set.UserStorySet()
- us.AddUserStory(DummyLocalUserStory(TestSharedPageState))
- us.AddUserStory(DummyLocalUserStory(TestSharedPageState))
- class Measurement(page_test.PageTest):
- @property
- def discard_first_result(self):
- return True
-
- def RunPage(self, page, _, results):
- results.AddValue(string.StringValue(page, 'test', 't', page.name))
-
- def ValidateAndMeasurePage(self, page, tab, results):
- pass
-
- results = results_options.CreateResults(
- EmptyMetadataForTest(), self.options)
- user_story_runner.Run(
- Measurement(), us, self.expectations, self.options, results)
-
- self.assertEquals(0, GetNumberOfSuccessfulPageRuns(results))
- self.assertEquals(0, len(results.failures))
- self.assertEquals(0, len(results.all_page_specific_values))
-
-
- results = results_options.CreateResults(
- EmptyMetadataForTest(), self.options)
- self.options.page_repeat = 1
- self.options.pageset_repeat = 2
- user_story_runner.Run(
- Measurement(), us, self.expectations, self.options, results)
- self.assertEquals(2, GetNumberOfSuccessfulPageRuns(results))
- self.assertEquals(0, len(results.failures))
- self.assertEquals(2, len(results.all_page_specific_values))
-
- results = results_options.CreateResults(
- EmptyMetadataForTest(), self.options)
- self.options.page_repeat = 2
- self.options.pageset_repeat = 1
- user_story_runner.Run(
- Measurement(), us, self.expectations, self.options, results)
- self.assertEquals(2, GetNumberOfSuccessfulPageRuns(results))
- self.assertEquals(0, len(results.failures))
- self.assertEquals(2, len(results.all_page_specific_values))
-
- results = results_options.CreateResults(
- EmptyMetadataForTest(), self.options)
- self.options.page_repeat = 1
- self.options.pageset_repeat = 1
- user_story_runner.Run(
- Measurement(), us, self.expectations, self.options, results)
- self.assertEquals(0, GetNumberOfSuccessfulPageRuns(results))
- self.assertEquals(0, len(results.failures))
- self.assertEquals(0, len(results.all_page_specific_values))
-
def testPagesetRepeat(self):
us = user_story_set.UserStorySet()
us.AddUserStory(DummyLocalUserStory(TestSharedPageState, name='blank'))
« no previous file with comments | « tools/telemetry/telemetry/user_story/user_story_runner.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698