tools/telemetry/telemetry/user_story/user_story_runner.py - Issue 962793004: [Telemetry] Make "discard_first_result" apply to user_stories too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/user_story/user_story_runner.py

Issue 962793004: [Telemetry] Make "discard_first_result" apply to user_stories too. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/results_options.py ('k') | tools/telemetry/telemetry/user_story/user_story_runner_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/user_story/user_story_runner.py

diff --git a/tools/telemetry/telemetry/user_story/user_story_runner.py b/tools/telemetry/telemetry/user_story/user_story_runner.py

index 1bb6b9551d0a3a2d2a28c1e1f7eebf3d10ca9362..ed2dddd3449d4922df8ac9e070996c16abf784f2 100644

--- a/tools/telemetry/telemetry/user_story/user_story_runner.py

+++ b/tools/telemetry/telemetry/user_story/user_story_runner.py

@@ -218,7 +218,6 @@ def Run(test, user_story_set, expectations, finder_options, results,

user_story_groups = GetUserStoryGroupsWithSameSharedUserStoryClass(

user_stories)

- user_story_with_discarded_first_results = set()

for group in user_story_groups:

state = None

@@ -250,14 +249,7 @@ def Run(test, user_story_set, expectations, finder_options, results,

try:

if state:

_CheckThermalThrottling(state.platform)

- # TODO(slamm): Make discard_first_result part of user_story API.

- # https://crbug.com/440101

- discard_current_run = (

- getattr(test, 'discard_first_result', False) and

- user_story not in user_story_with_discarded_first_results)

- if discard_current_run:

- user_story_with_discarded_first_results.add(user_story)

- results.DidRunPage(user_story, discard_run=discard_current_run)

+ results.DidRunPage(user_story)

except Exception:

if not has_existing_exception:

raise