tools/telemetry/telemetry/benchmark_unittest.py - Issue 962793004: [Telemetry] Make "discard_first_result" apply to user_stories too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/benchmark_unittest.py

Issue 962793004: [Telemetry] Make "discard_first_result" apply to user_stories too. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/benchmark_unittest.py

diff --git a/tools/telemetry/telemetry/benchmark_unittest.py b/tools/telemetry/telemetry/benchmark_unittest.py

index 4335a78ab76797a8956bc75075a47ac08f4be0ca..2bdcccc8cf198bfbbcd65b8b460a57bf17912bb6 100644

--- a/tools/telemetry/telemetry/benchmark_unittest.py

+++ b/tools/telemetry/telemetry/benchmark_unittest.py

@@ -132,7 +132,7 @@ class BenchmarkTest(unittest.TestCase):

def testBenchmarkPredicate(self):

class PredicateBenchmark(TestBenchmark):

@classmethod

- def ValueCanBeAddedPredicate(cls, value):

+ def ValueCanBeAddedPredicate(cls, value, is_first_result):

return False

original_run_fn = user_story_runner.Run

« no previous file with comments | « tools/telemetry/telemetry/benchmark.py ('k') | tools/telemetry/telemetry/results/page_test_results.py » ('j') | no next file with comments »