Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: tools/telemetry/telemetry/benchmark.py

Issue 962793004: [Telemetry] Make "discard_first_result" apply to user_stories too. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/startup.py ('k') | tools/telemetry/telemetry/benchmark_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/benchmark.py
diff --git a/tools/telemetry/telemetry/benchmark.py b/tools/telemetry/telemetry/benchmark.py
index f86393c4d2aa5ef8687fac121b2d694ecc2dc2a7..1c42c0cb07466f1d8e87a47d9d0d4b643e49ee42 100644
--- a/tools/telemetry/telemetry/benchmark.py
+++ b/tools/telemetry/telemetry/benchmark.py
@@ -138,17 +138,22 @@ class Benchmark(command_line.Command):
def ProcessCommandLineArgs(cls, parser, args):
pass
+ # pylint: disable=unused-argument
@classmethod
- def ValueCanBeAddedPredicate(cls, value): # pylint: disable=unused-argument
- """ Returns whether |value| can be added to the test results.
+ def ValueCanBeAddedPredicate(cls, value, is_first_result):
+ """Returns whether |value| can be added to the test results.
+
Override this method to customize the logic of adding values to test
results.
Args:
value: a value.Value instance.
+ is_first_result: True if |value| is the first result for its
+ corresponding user story.
- Returns: a boolean. True if value should be added to the test results and
- False otherwise.
+ Returns:
+ True if |value| should be added to the test results.
+ Otherwise, it returns False.
"""
return True
« no previous file with comments | « tools/perf/measurements/startup.py ('k') | tools/telemetry/telemetry/benchmark_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698