Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: tools/perf/benchmarks/page_cycler.py

Issue 962793004: [Telemetry] Make "discard_first_result" apply to user_stories too. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmarks/gpu_times.py ('k') | tools/perf/benchmarks/session_restore.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/page_cycler.py
diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py
index 770aed33d112c6ad38c08401840fd6d07e141c0f..0770b5cc96f27ec3615155fb9840948ccef7c62c 100644
--- a/tools/perf/benchmarks/page_cycler.py
+++ b/tools/perf/benchmarks/page_cycler.py
@@ -9,6 +9,7 @@ from telemetry import benchmark
class _PageCycler(benchmark.Benchmark):
options = {'pageset_repeat': 6}
+ cold_load_percent = 50 # % of page visits for which a cold load is forced
@classmethod
def Name(cls):
@@ -20,14 +21,15 @@ class _PageCycler(benchmark.Benchmark):
action='store_true',
help='Enable the speed index metric.')
- parser.add_option('--cold-load-percent', type='int', default=50,
- help='%d of page visits for which a cold load is forced')
+ @classmethod
+ def ValueCanBeAddedPredicate(cls, _, is_first_result):
+ return cls.cold_load_percent > 0 or not is_first_result
def CreatePageTest(self, options):
return page_cycler.PageCycler(
page_repeat = options.page_repeat,
pageset_repeat = options.pageset_repeat,
- cold_load_percent = options.cold_load_percent,
+ cold_load_percent = self.cold_load_percent,
report_speed_index = options.report_speed_index)
@@ -139,10 +141,10 @@ class PageCyclerNetsimTop10(_PageCycler):
tag = 'netsim'
page_set = page_sets.Top10PageSet
options = {
- 'cold_load_percent': 100,
'extra_wpr_args_as_string': '--shaping_type=proxy --net=cable',
'pageset_repeat': 6,
}
+ cold_load_percent = 100
@classmethod
def Name(cls):
@@ -152,7 +154,7 @@ class PageCyclerNetsimTop10(_PageCycler):
return page_cycler.PageCycler(
page_repeat = options.page_repeat,
pageset_repeat = options.pageset_repeat,
- cold_load_percent = options.cold_load_percent,
+ cold_load_percent = self.cold_load_percent,
report_speed_index = options.report_speed_index,
clear_cache_before_each_run = True)
« no previous file with comments | « tools/perf/benchmarks/gpu_times.py ('k') | tools/perf/benchmarks/session_restore.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698