tools/perf/benchmarks/gpu_times.py - Issue 962793004: [Telemetry] Make "discard_first_result" apply to user_stories too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/gpu_times.py

Issue 962793004: [Telemetry] Make "discard_first_result" apply to user_stories too. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/gpu_times.py

diff --git a/tools/perf/benchmarks/gpu_times.py b/tools/perf/benchmarks/gpu_times.py

index c2ccd0ec7f90f024a6dccdd7e1ff377db381c702..41fa991db5e6f8509b35766d632fdc8590ad8e59 100644

--- a/tools/perf/benchmarks/gpu_times.py

+++ b/tools/perf/benchmarks/gpu_times.py

@@ -27,7 +27,7 @@ class _GPUTimes(benchmark.Benchmark):

get_metrics_from_flags_callback=_GetGPUTimelineMetric)

@classmethod

- def ValueCanBeAddedPredicate(cls, value):

+ def ValueCanBeAddedPredicate(cls, value, _):

return (isinstance(value, gpu_timeline.GPUTimelineListOfValues) or

isinstance(value, gpu_timeline.GPUTimelineValue))

« no previous file with comments | « no previous file | tools/perf/benchmarks/page_cycler.py » ('j') | no next file with comments »