gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt - Issue 962723002: Change CHROMIUM_image declarations to support multi planar input.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt

Issue 962723002: Change CHROMIUM_image declarations to support multi planar input. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mcasas@comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/compositor/buffer_queue.cc ('K') | « content/browser/compositor/buffer_queue_unittest.cc ('k') | gpu/GLES2/gl2extchromium.h » ('j') | gpu/command_buffer/client/gles2_implementation.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt

diff --git a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt

index 2974e43bd32b7d01d4384cb62c7011a90d07a660..65897197e5a51219f81c34f103da5712fd12c0e3 100644

--- a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt

+++ b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt

@@ -29,18 +29,23 @@ New Tokens

New Procedures and Functions

- GLuint CreateImageCHROMIUM(ClientBuffer buffer,

+ GLuint CreateImageCHROMIUM(ClientBuffer* buffers,

GLsizei width,

GLsizei height,

GLenum internalformat)

- Create an image from <buffer> with width equal to <width> and

+ Create an image from <buffers> with width equal to <width> and

height equal to <height> and format equal to <internalformat>.

+ <buffers> specifies an array in which ClientBuffer elements corresponding

+ to image planes are stored. The number of ClientBuffer objects are inferred

+ through the specified <internalformat>.

Returns a unique identifier for the image that could be used in

subsequent operations.

- INVALID_VALUE is generated if <width> or <height> is nonpositive.

+ INVALID_VALUE is generated if <buffers> is invalid or <width> or <height>

reveman 2015/03/02 20:09:55 What does it mean for <buffers> to be invalid?

emircan 2015/03/03 02:02:18 Explained that it is an empty pointer.

+ is nonpositive.

INVALID_ENUM is generated if <internalformat> is not one of

RGB or RGBA.