gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt - Issue 962723002: Change CHROMIUM_image declarations to support multi planar input.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt

Issue 962723002: Change CHROMIUM_image declarations to support multi planar input. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mcasas@comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/compositor/buffer_queue.cc ('K') | « content/browser/compositor/buffer_queue_unittest.cc ('k') | gpu/GLES2/gl2extchromium.h » ('j') | gpu/command_buffer/client/gles2_implementation.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 Name	1 Name

2	2

3 CHROMIUM_image	3 CHROMIUM_image

4	4

5 Name Strings	5 Name Strings

6	6

7 GL_CHROMIUM_image	7 GL_CHROMIUM_image

8	8

9 Version	9 Version

10	10

(...skipping 11 matching lines...) Expand all Loading...
22 Issues	22 Issues

23	23

24 None	24 None

25	25

26 New Tokens	26 New Tokens

27	27

28 None	28 None

29	29

30 New Procedures and Functions	30 New Procedures and Functions

31	31

32 GLuint CreateImageCHROMIUM(ClientBuffer buffer,	32 GLuint CreateImageCHROMIUM(ClientBuffer* buffers,

33 GLsizei width,	33 GLsizei width,

34 GLsizei height,	34 GLsizei height,

35 GLenum internalformat)	35 GLenum internalformat)

36	36

37 Create an image from <buffer> with width equal to <width> and	37 Create an image from <buffers> with width equal to <width> and

38 height equal to <height> and format equal to <internalformat>.	38 height equal to <height> and format equal to <internalformat>.

39	39

	40 <buffers> specifies an array in which ClientBuffer elements corresponding

	41 to image planes are stored. The number of ClientBuffer objects are inferred

	42 through the specified <internalformat>.

	43

40 Returns a unique identifier for the image that could be used in	44 Returns a unique identifier for the image that could be used in

41 subsequent operations.	45 subsequent operations.

42	46

43 INVALID_VALUE is generated if <width> or <height> is nonpositive.	47 INVALID_VALUE is generated if <buffers> is invalid or <width> or <height>
	reveman 2015/03/02 20:09:55 What does it mean for <buffers> to be invalid? What does it mean for <buffers> to be invalid? emircan 2015/03/03 02:02:18 Explained that it is an empty pointer. Show quoted text On 2015/03/02 20:09:55, reveman wrote: > What does it mean for <buffers> to be invalid? Explained that it is an empty pointer.
	48 is nonpositive.

44	49

45 INVALID_ENUM is generated if <internalformat> is not one of	50 INVALID_ENUM is generated if <internalformat> is not one of

46 RGB or RGBA.	51 RGB or RGBA.

47	52

48 void DestroyImageCHROMIUM(GLuint image_id)	53 void DestroyImageCHROMIUM(GLuint image_id)

49	54

50 Frees the image previously created by a call to CreateImageCHROMIUM.	55 Frees the image previously created by a call to CreateImageCHROMIUM.

51	56

52 INVALID_OPERATION is generated if <image_id> is not a valid image id.	57 INVALID_OPERATION is generated if <image_id> is not a valid image id.

53	58

54 Errors	59 Errors

55	60

56 None.	61 None.

57	62

58 New State	63 New State

59	64

60 None.	65 None.

61	66

62 Revision History	67 Revision History

63	68

64 5/9/2013 Documented the extension	69 5/9/2013 Documented the extension

65 4/30/2014 Moved usage flag to creation function.	70 4/30/2014 Moved usage flag to creation function.

66 10/7/2014 Remove map/unmap API.	71 10/7/2014 Remove map/unmap API.

OLD	NEW