Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: gpu/command_buffer/client/gles2_implementation_unittest.cc

Issue 962723002: Change CHROMIUM_image declarations to support multi planar input. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changing the function calls Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/client/gles2_implementation_unittest.cc
diff --git a/gpu/command_buffer/client/gles2_implementation_unittest.cc b/gpu/command_buffer/client/gles2_implementation_unittest.cc
index 2acbc6356399a37b7ac65b97a4f2a95461dddfeb..3bd79c998e54079166069dc2e512f1d7fe906744 100644
--- a/gpu/command_buffer/client/gles2_implementation_unittest.cc
+++ b/gpu/command_buffer/client/gles2_implementation_unittest.cc
@@ -3367,6 +3367,16 @@ TEST_F(GLES2ImplementationTest, CreateAndConsumeTextureCHROMIUM) {
EXPECT_EQ(kTexturesStartId, id);
}
+TEST_F(GLES2ImplementationTest, CreateImageCHROMIUM) {
mcasas 2015/02/28 01:14:26 CreateImageCHROMIUM as test name is a bit misleadi
emircan 2015/02/28 02:33:36 Renamed it. Will add more tests as implementation
+ EXPECT_CALL(*command_buffer(), OnFlush())
+ .Times(1)
+ .RetiresOnSaturation();
mcasas 2015/02/28 01:14:26 I think l.3371-3373 can be put in one line (no nee
emircan 2015/02/28 02:33:36 Done.
+ GLuint image_id = gl_->CreateImageCHROMIUM(
+ nullptr, 10, 10, GL_RGBA);
mcasas 2015/02/28 01:14:26 Fits in one line?
emircan 2015/02/28 02:33:36 Fits, sorry for mssing that.
+ EXPECT_EQ(0u, image_id);
+ EXPECT_EQ(static_cast<GLenum>(GL_INVALID_VALUE), gl_->GetError());
+}
+
TEST_F(GLES2ImplementationTest, ProduceTextureCHROMIUM) {
struct Cmds {
cmds::ProduceTextureCHROMIUMImmediate cmd;

Powered by Google App Engine
This is Rietveld 408576698