Change CHROMIUM_image declarations to support multi planar input.

gpu/command_buffer/client/gles2_implementation_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Tests for GLES2Implementation.
 
 #include "gpu/command_buffer/client/gles2_implementation.h"
 
 #include <limits>
 
@@ skipping 3349 matching lines @@
   };
 
   Mailbox mailbox = Mailbox::Generate();
   Cmds expected;
   expected.cmd.Init(GL_TEXTURE_2D, kTexturesStartId, mailbox.name);
   GLuint id = gl_->CreateAndConsumeTextureCHROMIUM(GL_TEXTURE_2D, mailbox.name);
   EXPECT_EQ(0, memcmp(&expected, commands_, sizeof(expected)));
   EXPECT_EQ(kTexturesStartId, id);
 }
 
+TEST_F(GLES2ImplementationTest, CreateImageCHROMIUM) {

[mcasas, 2015/02/28 01:14:26]

CreateImageCHROMIUM as test name is a bit misleading, since this is a 
negative test case, expecting error. Rename or, if you plan to make it a
positive test case in the future, add some comment/TODO about it. I'd
rename it a keep this negative test case, adding the positive later on.

[emircan, 2015/02/28 02:33:36]

Renamed it. Will add more tests as implementation are added.

+  EXPECT_CALL(*command_buffer(), OnFlush())
+      .Times(1)
+      .RetiresOnSaturation();

[mcasas, 2015/02/28 01:14:26]

I think l.3371-3373 can be put in one line (no need to separate the
expectation's lines).

[emircan, 2015/02/28 02:33:36]

Done.

+  GLuint image_id = gl_->CreateImageCHROMIUM(
+      nullptr, 10, 10, GL_RGBA);

[mcasas, 2015/02/28 01:14:26]

Fits in one line?

[emircan, 2015/02/28 02:33:36]

Fits, sorry for mssing that.

+  EXPECT_EQ(0u, image_id);
+  EXPECT_EQ(static_cast<GLenum>(GL_INVALID_VALUE), gl_->GetError());
+}
+
 TEST_F(GLES2ImplementationTest, ProduceTextureCHROMIUM) {
   struct Cmds {
     cmds::ProduceTextureCHROMIUMImmediate cmd;
     GLbyte data[64];
   };
 
   Mailbox mailbox = Mailbox::Generate();
   Cmds expected;
   expected.cmd.Init(GL_TEXTURE_2D, mailbox.name);
   gl_->ProduceTextureCHROMIUM(GL_TEXTURE_2D, mailbox.name);
@@ skipping 304 matching lines @@
 TEST_F(GLES2ImplementationManualInitTest, FailInitOnTransferBufferFail) {
   ContextInitOptions init_options;
   init_options.transfer_buffer_initialize_fail = true;
   EXPECT_FALSE(Initialize(init_options));
 }
 
 #include "gpu/command_buffer/client/gles2_implementation_unittest_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu