components/autofill/content/renderer/password_autofill_agent.h - Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Modified to resolve bot breakages. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/form_autofill_util.h ('K') | « components/autofill/content/renderer/form_autofill_util.cc ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | components/autofill/content/renderer/password_autofill_agent.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_autofill_agent.h

diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h

index 9f070f358b8419d2cb33f3112f50cb75261f1870..b221c2c118995edb5fceaa4df1c4d47c98b5cc9f 100644

--- a/components/autofill/content/renderer/password_autofill_agent.h

+++ b/components/autofill/content/renderer/password_autofill_agent.h

@@ -287,9 +287,8 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {

// True indicates that the password field was autofilled, false otherwise.

bool was_password_autofilled_;

- // Records original starting point of username element's selection range

- // before preview.

- int username_selection_start_;

+ // Records the username typed before preview the suggestions.

vabr (Chromium) 2015/07/09 06:17:51 nit: preview the suggestions -> suggestions previe

Pritam Nikam 2015/07/10 16:58:46 Done.

+ base::string16 username_query_prefix_;

// True indicates that all frames in a page have been rendered.

bool did_stop_loading_;