[Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

components/autofill/content/renderer/form_autofill_util.h

Index: components/autofill/content/renderer/form_autofill_util.h
diff --git a/components/autofill/content/renderer/form_autofill_util.h b/components/autofill/content/renderer/form_autofill_util.h
index 1be05cdac08433fab3baf5dd2e293ea3d2af413c..f6aceb4e0e5f086857620b59dedc88e22ada708e 100644
--- a/components/autofill/content/renderer/form_autofill_util.h
+++ b/components/autofill/content/renderer/form_autofill_util.h
@@ -176,6 +176,15 @@ bool IsWebElementEmpty(const blink::WebElement& element);
 // Return a gfx::RectF that is the bounding box for |element| scaled by |scale|.
 gfx::RectF GetScaledBoundingBox(float scale, blink::WebElement* element);
 
+// Previews the |input_element| with supplied |suggestion| and |user_input|.

[vabr (Chromium), 2015/07/09 08:27:49]

nit: This comment is hard to understand. It is not clear what "previews" mean,
it is not clear that |user_input| is assumed to be a substring (or prefix, since
it only highlights the last part of |suggestion| not included in |user_input|?)
of |suggestion|, and that |suggestion| is assumed to be already visible in the
field to the user. Could you please improve the comment to clearly say both (A)
what the function does, and (B) what exactly are the expectations about the
arguments?

[Pritam Nikam, 2015/07/10 16:58:45]

Done.

+// |input_element| should not be null.
+// Not using input_element->value() and input_element->suggestedValue()
+// directly because password manager sometimes does not set them.

[vabr (Chromium), 2015/07/09 06:17:51]

This looks very suspiciously. What does "sometimes" mean? I do not like the idea
that there is perhaps a bug in how PasswordAutofillAgent (not password manager)
handles value setting, but we just paper it over. Could we please clarify this?

[vabr (Chromium), 2015/07/09 08:27:49]

This has been resolved in http://crbug.com/507714, but please see the new
comments.

[Pritam Nikam, 2015/07/10 16:58:45]

Acknowledged.

+// http://crbug.com/507714
+void PreviewSuggestion(const base::string16& suggestion,
+                       const base::string16& user_input,
+                       blink::WebFormControlElement* input_element);
+
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_FORM_AUTOFILL_UTIL_H_