components/autofill/content/renderer/form_autofill_util.h - Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/form_autofill_util.h

Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated Rouslan's review comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/autofill_agent.cc ('k') | components/autofill/content/renderer/form_autofill_util.cc » ('j') | components/autofill/core/common/autofill_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/form_autofill_util.h

diff --git a/components/autofill/content/renderer/form_autofill_util.h b/components/autofill/content/renderer/form_autofill_util.h

index 1be05cdac08433fab3baf5dd2e293ea3d2af413c..f6aceb4e0e5f086857620b59dedc88e22ada708e 100644

--- a/components/autofill/content/renderer/form_autofill_util.h

+++ b/components/autofill/content/renderer/form_autofill_util.h

@@ -176,6 +176,15 @@ bool IsWebElementEmpty(const blink::WebElement& element);

// Return a gfx::RectF that is the bounding box for |element| scaled by |scale|.

gfx::RectF GetScaledBoundingBox(float scale, blink::WebElement* element);

+// |input_element| should not be null.

+// Not using input_element->value() and input_element->suggestedValue()

+// directly because password manager sometimes does not set them.

+// http://crbug.com/507714

+void PreviewSuggestion(const base::string16& suggestion,

+ const base::string16& user_input,

+ blink::WebFormControlElement* input_element);

} // namespace autofill

#endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_FORM_AUTOFILL_UTIL_H_