components/autofill/content/renderer/autofill_agent.cc - Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated Rouslan's review comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill.gypi ('k') | components/autofill/content/renderer/form_autofill_util.h » ('j') | components/autofill/core/common/autofill_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/autofill_agent.cc

diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc

index d1ea08856d48c2791e0421e916b8050889c43f48..cd1525f15ce20cebf9ab7f285df01bc6943dd588 100644

--- a/components/autofill/content/renderer/autofill_agent.cc

+++ b/components/autofill/content/renderer/autofill_agent.cc

@@ -744,8 +744,7 @@ void AutofillAgent::PreviewFieldWithValue(const base::string16& value,

was_query_node_autofilled_ = element_.isAutofilled();

node->setSuggestedValue(value.substr(0, node->maxLength()));

node->setAutofilled(true);

- node->setSelectionRange(node->value().length(),

- node->suggestedValue().length());

+ PreviewSuggestion(node->suggestedValue(), node->value(), node);

}

void AutofillAgent::ProcessForms() {

« no previous file with comments | « components/autofill.gypi ('k') | components/autofill/content/renderer/form_autofill_util.h » ('j') | components/autofill/core/common/autofill_util.cc » ('J')