Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 962673002: Telemetry: remove the heap snapshot half-feature. (Closed)

Created:
5 years, 10 months ago by marja
Modified:
5 years, 9 months ago
Reviewers:
Sami
CC:
chromium-reviews, telemetry-reviews_chromium.org, Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemetry: remove the heap snapshot half-feature. It was never really taken into use (it was meant to be used by external tools but we never figured out how they should interact w/ Telemetry) and it's out of date. BUG=274456 R=skyostil@chromium.org Committed: https://crrev.com/a220c3513768558e8359726af125cbf8e504a727 Cr-Commit-Position: refs/heads/master@{#318703}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -461 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py View 1 2 2 chunks +0 lines, -23 lines 0 comments Download
D tools/telemetry/telemetry/core/heap/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/telemetry/telemetry/core/heap/chrome_js_heap_snapshot_parser.py View 1 chunk +0 lines, -248 lines 0 comments Download
D tools/telemetry/telemetry/core/heap/chrome_js_heap_snapshot_parser_unittest.py View 1 chunk +0 lines, -57 lines 0 comments Download
D tools/telemetry/telemetry/core/heap/live_heap_object.py View 1 chunk +0 lines, -57 lines 0 comments Download
D tools/telemetry/telemetry/core/heap/model.py View 1 chunk +0 lines, -22 lines 0 comments Download
D tools/telemetry/telemetry/core/heap/retaining_edge.py View 1 chunk +0 lines, -52 lines 0 comments Download
M tools/telemetry/telemetry/core/web_contents.py View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
marja
ptal (are there telemetry tryjobs so that i could actually notice if i got this ...
5 years, 10 months ago (2015-02-26 16:21:43 UTC) #1
Sami
Yay, red patch. lgtm, but looks like you need a rebase. The telemetry smoke and ...
5 years, 10 months ago (2015-02-26 19:10:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962673002/20001
5 years, 9 months ago (2015-03-02 13:55:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/38365)
5 years, 9 months ago (2015-03-02 14:57:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/962673002/40001
5 years, 9 months ago (2015-03-02 15:03:39 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-02 16:00:18 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 16:00:52 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a220c3513768558e8359726af125cbf8e504a727
Cr-Commit-Position: refs/heads/master@{#318703}

Powered by Google App Engine
This is Rietveld 408576698