Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

Issue 962673002: Telemetry: remove the heap snapshot half-feature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: oops Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/heap/__init__.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
index b8483be1ebefa8470884bea8a63173646ac4151f..59cc3742347403c6f4a1b7eebd67da5139c585b7 100644
--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
@@ -17,7 +17,6 @@ from telemetry.core.backends.chrome_inspector import inspector_page
from telemetry.core.backends.chrome_inspector import inspector_runtime
from telemetry.core.backends.chrome_inspector import inspector_websocket
from telemetry.core.backends.chrome_inspector import websocket
-from telemetry.core.heap import model as heap_model_module
from telemetry.image_processing import image_util
from telemetry.timeline import model as timeline_model_module
from telemetry.timeline import trace_data as trace_data_module
@@ -240,25 +239,3 @@ class InspectorBackend(object):
self._page.CollectGarbage()
except (socket.error, websocket.WebSocketException) as e:
self._HandleError(e)
-
- def TakeJSHeapSnapshot(self, timeout=120):
- snapshot = []
-
- def OnNotification(res):
- if res['method'] == 'HeapProfiler.addHeapSnapshotChunk':
- snapshot.append(res['params']['chunk'])
-
- try:
- self._websocket.RegisterDomain('HeapProfiler', OnNotification)
-
- self._websocket.SyncRequest({'method': 'Page.getResourceTree'}, timeout)
- self._websocket.SyncRequest({'method': 'Debugger.enable'}, timeout)
- self._websocket.SyncRequest(
- {'method': 'HeapProfiler.takeHeapSnapshot'}, timeout)
- except (socket.error, websocket.WebSocketException) as e:
- self._HandleError(e)
-
- snapshot = ''.join(snapshot)
-
- self.UnregisterDomain('HeapProfiler')
- return heap_model_module.Model(snapshot)
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/heap/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698