Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 962643003: Update the ICU data (Closed)

Created:
5 years, 9 months ago by jungshik at Google
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update the ICU data Fix the following errors found by jochen@ in https://codereview.chromium.org/960263002/ 1. brkitr: en_US_POSIX is not supported. Remove it from brklocal.mk : We don't use en_US_POSIX and the remaining dependency on it in some unittests was already removed. (we may need it back later, though, for breaking an FQDN into components.) 2. coll: Explicitly add id.txt required as the alias/parent of "in" and "id_ID". This should not affect the collation in Indonesian locale because falling back to the root locale should be fine. 3. lang: Add 'ro_MD.txt' required as the alias of 'mo.txt'. Also update make_mac_asseymbly.sh to get it to read off the ICU major version automatically. Besides, update README.chromium to refer to ICU 54 as done by the aforementioned CL. Rebuild the data files and assembly sources (the latter still required by stand-alone v8 builds) for all the platforms. icudtl.dll for Windows will be built and checked in in another CL. BUG=428145 TEST=Usual ICU update tests before rolling DEPS. See https://codereview.chromium.org/878723002 TBR=jochen@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/db16fd86566ffdecce9d4b8e61e21d5316626537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M README.chromium View 2 chunks +12 lines, -12 lines 0 comments Download
M android/brkitr.patch View 2 chunks +2 lines, -2 lines 0 comments Download
M android/icudtl.dat View Binary file 0 comments Download
M scripts/make_mac_assembly.sh View 1 chunk +6 lines, -3 lines 0 comments Download
M source/data/brkitr/brklocal.mk View 1 chunk +1 line, -1 line 0 comments Download
M source/data/coll/collocal.mk View 1 chunk +1 line, -1 line 0 comments Download
M source/data/in/icudtl.dat View Binary file 0 comments Download
M source/data/lang/reslocal.mk View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
Jochen, I believe that I've fixed the issue you came across in https://codereview.chromium.org/960263002/ If you ...
5 years, 9 months ago (2015-03-02 07:51:59 UTC) #1
jungshik at Google
5 years, 9 months ago (2015-03-02 08:02:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db16fd86566ffdecce9d4b8e61e21d5316626537 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698